string.c
48 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
1001
1002
1003
1004
1005
1006
1007
1008
1009
1010
1011
1012
1013
1014
1015
1016
1017
1018
1019
1020
1021
1022
1023
1024
1025
1026
1027
1028
1029
1030
1031
1032
1033
1034
1035
1036
1037
1038
1039
1040
1041
1042
1043
1044
1045
1046
1047
1048
1049
1050
1051
1052
1053
1054
1055
1056
1057
1058
1059
1060
1061
1062
1063
1064
1065
1066
1067
1068
1069
1070
1071
1072
1073
1074
1075
1076
1077
1078
1079
1080
1081
1082
1083
1084
1085
1086
1087
1088
1089
1090
1091
1092
1093
1094
1095
1096
1097
1098
1099
1100
1101
1102
1103
1104
1105
1106
1107
1108
1109
1110
1111
1112
1113
1114
1115
1116
1117
1118
1119
1120
1121
1122
1123
1124
1125
1126
1127
1128
1129
1130
1131
1132
1133
1134
1135
1136
1137
1138
1139
1140
1141
1142
1143
1144
1145
1146
1147
1148
1149
1150
1151
1152
1153
1154
1155
1156
1157
1158
1159
1160
1161
1162
1163
1164
1165
1166
1167
1168
1169
1170
1171
1172
1173
1174
1175
1176
1177
1178
1179
1180
1181
1182
1183
1184
1185
1186
1187
1188
1189
1190
1191
1192
1193
1194
1195
1196
1197
1198
1199
1200
1201
1202
1203
1204
1205
1206
1207
1208
1209
1210
1211
1212
1213
1214
1215
1216
1217
1218
1219
1220
1221
1222
1223
1224
1225
1226
1227
1228
1229
1230
1231
1232
1233
1234
1235
1236
1237
1238
1239
1240
1241
1242
1243
1244
1245
1246
1247
1248
1249
1250
1251
1252
1253
1254
1255
1256
1257
1258
1259
1260
1261
1262
1263
1264
1265
1266
1267
1268
1269
1270
1271
1272
1273
1274
1275
1276
1277
1278
1279
1280
1281
1282
1283
1284
1285
1286
1287
1288
1289
1290
1291
1292
1293
1294
1295
1296
1297
1298
1299
1300
1301
1302
1303
1304
1305
1306
1307
1308
1309
1310
1311
1312
1313
1314
1315
1316
1317
1318
1319
1320
1321
1322
1323
1324
1325
1326
1327
1328
1329
1330
1331
1332
1333
1334
1335
1336
1337
1338
1339
1340
1341
1342
1343
1344
1345
1346
1347
1348
1349
1350
1351
1352
1353
1354
1355
1356
1357
1358
1359
1360
1361
1362
1363
1364
1365
1366
1367
1368
1369
1370
1371
1372
1373
1374
1375
1376
1377
1378
1379
1380
1381
1382
1383
1384
1385
1386
1387
1388
1389
1390
1391
1392
1393
1394
1395
1396
1397
1398
1399
1400
1401
1402
1403
1404
1405
1406
1407
1408
1409
1410
1411
1412
1413
1414
1415
1416
1417
1418
1419
1420
1421
1422
1423
1424
1425
1426
1427
1428
1429
1430
1431
1432
1433
1434
1435
1436
1437
1438
1439
1440
1441
1442
1443
1444
1445
1446
1447
1448
1449
1450
1451
1452
1453
1454
1455
1456
1457
1458
1459
1460
1461
1462
1463
1464
1465
1466
1467
1468
1469
1470
1471
1472
1473
1474
1475
1476
1477
1478
1479
1480
1481
1482
1483
1484
1485
1486
1487
1488
1489
1490
1491
1492
1493
1494
1495
1496
1497
1498
1499
1500
1501
1502
1503
1504
1505
1506
1507
1508
1509
1510
1511
1512
1513
1514
1515
1516
1517
1518
1519
1520
1521
1522
1523
1524
1525
1526
1527
1528
1529
1530
1531
1532
1533
1534
1535
1536
1537
1538
1539
1540
1541
1542
1543
1544
1545
1546
1547
1548
1549
1550
1551
1552
1553
1554
1555
1556
1557
1558
1559
1560
1561
1562
1563
1564
1565
1566
1567
1568
1569
1570
1571
1572
1573
1574
1575
1576
1577
1578
1579
1580
1581
1582
1583
1584
1585
1586
1587
1588
1589
1590
1591
1592
1593
1594
1595
1596
1597
1598
1599
1600
1601
1602
1603
1604
1605
1606
1607
1608
1609
1610
1611
1612
1613
1614
1615
1616
1617
1618
1619
1620
1621
1622
1623
1624
1625
1626
1627
1628
1629
1630
1631
1632
1633
1634
1635
1636
1637
1638
1639
1640
// RUN: %clang_analyze_cc1 -verify %s -Wno-null-dereference \
// RUN: -analyzer-checker=core \
// RUN: -analyzer-checker=unix.cstring \
// RUN: -analyzer-checker=unix.Malloc \
// RUN: -analyzer-checker=alpha.unix.cstring \
// RUN: -analyzer-checker=debug.ExprInspection \
// RUN: -analyzer-config eagerly-assume=false
//
// RUN: %clang_analyze_cc1 -verify %s -Wno-null-dereference -DUSE_BUILTINS \
// RUN: -analyzer-checker=core \
// RUN: -analyzer-checker=unix.cstring \
// RUN: -analyzer-checker=unix.Malloc \
// RUN: -analyzer-checker=alpha.unix.cstring \
// RUN: -analyzer-checker=debug.ExprInspection \
// RUN: -analyzer-config eagerly-assume=false
//
// RUN: %clang_analyze_cc1 -verify %s -Wno-null-dereference -DVARIANT \
// RUN: -analyzer-checker=core \
// RUN: -analyzer-checker=unix.cstring \
// RUN: -analyzer-checker=unix.Malloc \
// RUN: -analyzer-checker=alpha.unix.cstring \
// RUN: -analyzer-checker=debug.ExprInspection \
// RUN: -analyzer-config eagerly-assume=false
//
// RUN: %clang_analyze_cc1 -verify %s -Wno-null-dereference \
// RUN: -DUSE_BUILTINS -DVARIANT \
// RUN: -analyzer-checker=core \
// RUN: -analyzer-checker=alpha.security.taint \
// RUN: -analyzer-checker=unix.cstring \
// RUN: -analyzer-checker=unix.Malloc \
// RUN: -analyzer-checker=alpha.unix.cstring \
// RUN: -analyzer-checker=debug.ExprInspection \
// RUN: -analyzer-config eagerly-assume=false
//
// RUN: %clang_analyze_cc1 -verify %s -Wno-null-dereference \
// RUN: -DSUPPRESS_OUT_OF_BOUND \
// RUN: -analyzer-checker=core \
// RUN: -analyzer-checker=unix.cstring \
// RUN: -analyzer-checker=unix.Malloc \
// RUN: -analyzer-checker=alpha.unix.cstring.BufferOverlap \
// RUN: -analyzer-checker=alpha.unix.cstring.NotNullTerminated \
// RUN: -analyzer-checker=debug.ExprInspection \
// RUN: -analyzer-config eagerly-assume=false
//===----------------------------------------------------------------------===
// Declarations
//===----------------------------------------------------------------------===
// Some functions are so similar to each other that they follow the same code
// path, such as memcpy and __memcpy_chk, or memcmp and bcmp. If VARIANT is
// defined, make sure to use the variants instead to make sure they are still
// checked by the analyzer.
// Some functions are implemented as builtins. These should be #defined as
// BUILTIN(f), which will prepend "__builtin_" if USE_BUILTINS is defined.
// Functions that have variants and are also available as builtins should be
// declared carefully! See memcpy() for an example.
#ifdef USE_BUILTINS
# define BUILTIN(f) __builtin_ ## f
#else /* USE_BUILTINS */
# define BUILTIN(f) f
#endif /* USE_BUILTINS */
#define NULL 0
typedef typeof(sizeof(int)) size_t;
void clang_analyzer_eval(int);
int scanf(const char *restrict format, ...);
void *malloc(size_t);
void free(void *);
//===----------------------------------------------------------------------===
// strlen()
//===----------------------------------------------------------------------===
#define strlen BUILTIN(strlen)
size_t strlen(const char *s);
void strlen_constant0() {
clang_analyzer_eval(strlen("123") == 3); // expected-warning{{TRUE}}
}
void strlen_constant1() {
const char *a = "123";
clang_analyzer_eval(strlen(a) == 3); // expected-warning{{TRUE}}
}
void strlen_constant2(char x) {
char a[] = "123";
clang_analyzer_eval(strlen(a) == 3); // expected-warning{{TRUE}}
a[0] = x;
clang_analyzer_eval(strlen(a) == 3); // expected-warning{{UNKNOWN}}
}
size_t strlen_null() {
return strlen(0); // expected-warning{{Null pointer passed as 1st argument to string length function}}
}
size_t strlen_fn() {
return strlen((char*)&strlen_fn); // expected-warning{{Argument to string length function is the address of the function 'strlen_fn', which is not a null-terminated string}}
}
size_t strlen_nonloc() {
label:
return strlen((char*)&&label); // expected-warning{{Argument to string length function is the address of the label 'label', which is not a null-terminated string}}
}
void strlen_subregion() {
struct two_strings { char a[2], b[2]; };
extern void use_two_strings(struct two_strings *);
struct two_strings z;
use_two_strings(&z);
size_t a = strlen(z.a);
z.b[0] = 5;
size_t b = strlen(z.a);
if (a == 0)
clang_analyzer_eval(b == 0); // expected-warning{{TRUE}}
use_two_strings(&z);
size_t c = strlen(z.a);
if (a == 0)
clang_analyzer_eval(c == 0); // expected-warning{{UNKNOWN}}
}
extern void use_string(char *);
void strlen_argument(char *x) {
size_t a = strlen(x);
size_t b = strlen(x);
if (a == 0)
clang_analyzer_eval(b == 0); // expected-warning{{TRUE}}
use_string(x);
size_t c = strlen(x);
if (a == 0)
clang_analyzer_eval(c == 0); // expected-warning{{UNKNOWN}}
}
extern char global_str[];
void strlen_global() {
size_t a = strlen(global_str);
size_t b = strlen(global_str);
if (a == 0) {
clang_analyzer_eval(b == 0); // expected-warning{{TRUE}}
// Make sure clang_analyzer_eval does not invalidate globals.
clang_analyzer_eval(strlen(global_str) == 0); // expected-warning{{TRUE}}
}
// Call a function with unknown effects, which should invalidate globals.
use_string(0);
size_t c = strlen(global_str);
if (a == 0)
clang_analyzer_eval(c == 0); // expected-warning{{UNKNOWN}}
}
void strlen_indirect(char *x) {
size_t a = strlen(x);
char *p = x;
char **p2 = &p;
size_t b = strlen(x);
if (a == 0)
clang_analyzer_eval(b == 0); // expected-warning{{TRUE}}
extern void use_string_ptr(char*const*);
use_string_ptr(p2);
size_t c = strlen(x);
if (a == 0)
clang_analyzer_eval(c == 0); // expected-warning{{UNKNOWN}}
}
void strlen_indirect2(char *x) {
size_t a = strlen(x);
char *p = x;
char **p2 = &p;
extern void use_string_ptr2(char**);
use_string_ptr2(p2);
size_t c = strlen(x);
if (a == 0)
clang_analyzer_eval(c == 0); // expected-warning{{UNKNOWN}}
}
void strlen_liveness(const char *x) {
if (strlen(x) < 5)
return;
clang_analyzer_eval(strlen(x) < 5); // expected-warning{{FALSE}}
}
size_t strlenWrapper(const char *str) {
return strlen(str);
}
extern void invalidate(char *s);
void testStrlenCallee() {
char str[42];
invalidate(str);
size_t lenBefore = strlenWrapper(str);
invalidate(str);
size_t lenAfter = strlenWrapper(str);
clang_analyzer_eval(lenBefore == lenAfter); // expected-warning{{UNKNOWN}}
}
//===----------------------------------------------------------------------===
// strnlen()
//===----------------------------------------------------------------------===
size_t strnlen(const char *s, size_t maxlen);
void strnlen_constant0() {
clang_analyzer_eval(strnlen("123", 10) == 3); // expected-warning{{TRUE}}
}
void strnlen_constant1() {
const char *a = "123";
clang_analyzer_eval(strnlen(a, 10) == 3); // expected-warning{{TRUE}}
}
void strnlen_constant2(char x) {
char a[] = "123";
clang_analyzer_eval(strnlen(a, 10) == 3); // expected-warning{{TRUE}}
a[0] = x;
clang_analyzer_eval(strnlen(a, 10) == 3); // expected-warning{{UNKNOWN}}
}
void strnlen_constant4() {
clang_analyzer_eval(strnlen("123456", 3) == 3); // expected-warning{{TRUE}}
}
void strnlen_constant5() {
const char *a = "123456";
clang_analyzer_eval(strnlen(a, 3) == 3); // expected-warning{{TRUE}}
}
void strnlen_constant6(char x) {
char a[] = "123456";
clang_analyzer_eval(strnlen(a, 3) == 3); // expected-warning{{TRUE}}
a[0] = x;
clang_analyzer_eval(strnlen(a, 3) == 3); // expected-warning{{UNKNOWN}}
}
size_t strnlen_null() {
return strnlen(0, 3); // expected-warning{{Null pointer passed as 1st argument to string length function}}
}
size_t strnlen_fn() {
return strnlen((char*)&strlen_fn, 3); // expected-warning{{Argument to string length function is the address of the function 'strlen_fn', which is not a null-terminated string}}
}
size_t strnlen_nonloc() {
label:
return strnlen((char*)&&label, 3); // expected-warning{{Argument to string length function is the address of the label 'label', which is not a null-terminated string}}
}
void strnlen_zero() {
clang_analyzer_eval(strnlen("abc", 0) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strnlen(NULL, 0) == 0); // expected-warning{{TRUE}}
}
size_t strnlen_compound_literal() {
// This used to crash because we don't model the string lengths of
// compound literals.
return strnlen((char[]) { 'a', 'b', 0 }, 1);
}
size_t strnlen_unknown_limit(float f) {
// This used to crash because we don't model the integer values of floats.
return strnlen("abc", (int)f);
}
void strnlen_is_not_strlen(char *x) {
clang_analyzer_eval(strnlen(x, 10) == strlen(x)); // expected-warning{{UNKNOWN}}
}
void strnlen_at_limit(char *x) {
size_t len = strnlen(x, 10);
clang_analyzer_eval(len <= 10); // expected-warning{{TRUE}}
clang_analyzer_eval(len == 10); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(len < 10); // expected-warning{{UNKNOWN}}
}
void strnlen_at_actual(size_t limit) {
size_t len = strnlen("abc", limit);
clang_analyzer_eval(len <= 3); // expected-warning{{TRUE}}
// This is due to eager assertion in strnlen.
if (limit == 0) {
clang_analyzer_eval(len == 0); // expected-warning{{TRUE}}
} else {
clang_analyzer_eval(len == 3); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(len < 3); // expected-warning{{UNKNOWN}}
}
}
//===----------------------------------------------------------------------===
// strcpy()
//===----------------------------------------------------------------------===
#ifdef VARIANT
#define __strcpy_chk BUILTIN(__strcpy_chk)
char *__strcpy_chk(char *restrict s1, const char *restrict s2, size_t destlen);
#define strcpy(a,b) __strcpy_chk(a,b,(size_t)-1)
#else /* VARIANT */
#define strcpy BUILTIN(strcpy)
char *strcpy(char *restrict s1, const char *restrict s2);
#endif /* VARIANT */
void strcpy_null_dst(char *x) {
strcpy(NULL, x); // expected-warning{{Null pointer passed as 1st argument to string copy function}}
}
void strcpy_null_src(char *x) {
strcpy(x, NULL); // expected-warning{{Null pointer passed as 2nd argument to string copy function}}
}
void strcpy_fn(char *x) {
strcpy(x, (char*)&strcpy_fn); // expected-warning{{Argument to string copy function is the address of the function 'strcpy_fn', which is not a null-terminated string}}
}
void strcpy_fn_const(char *x) {
strcpy(x, (const char*)&strcpy_fn); // expected-warning{{Argument to string copy function is the address of the function 'strcpy_fn', which is not a null-terminated string}}
}
extern int globalInt;
void strcpy_effects(char *x, char *y) {
char a = x[0];
if (globalInt != 42)
return;
clang_analyzer_eval(strcpy(x, y) == x); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(x) == strlen(y)); // expected-warning{{TRUE}}
clang_analyzer_eval(a == x[0]); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(globalInt == 42); // expected-warning{{TRUE}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
void strcpy_overflow(char *y) {
char x[4];
if (strlen(y) == 4)
strcpy(x, y); // expected-warning{{String copy function overflows the destination buffer}}
}
#endif
void strcpy_no_overflow(char *y) {
char x[4];
if (strlen(y) == 3)
strcpy(x, y); // no-warning
}
//===----------------------------------------------------------------------===
// stpcpy()
//===----------------------------------------------------------------------===
#ifdef VARIANT
#define __stpcpy_chk BUILTIN(__stpcpy_chk)
char *__stpcpy_chk(char *restrict s1, const char *restrict s2, size_t destlen);
#define stpcpy(a,b) __stpcpy_chk(a,b,(size_t)-1)
#else /* VARIANT */
#define stpcpy BUILTIN(stpcpy)
char *stpcpy(char *restrict s1, const char *restrict s2);
#endif /* VARIANT */
void stpcpy_effect(char *x, char *y) {
char a = x[0];
clang_analyzer_eval(stpcpy(x, y) == &x[strlen(y)]); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(x) == strlen(y)); // expected-warning{{TRUE}}
clang_analyzer_eval(a == x[0]); // expected-warning{{UNKNOWN}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
void stpcpy_overflow(char *y) {
char x[4];
if (strlen(y) == 4)
stpcpy(x, y); // expected-warning{{String copy function overflows the destination buffer}}
}
#endif
void stpcpy_no_overflow(char *y) {
char x[4];
if (strlen(y) == 3)
stpcpy(x, y); // no-warning
}
//===----------------------------------------------------------------------===
// strcat()
//===----------------------------------------------------------------------===
#ifdef VARIANT
#define __strcat_chk BUILTIN(__strcat_chk)
char *__strcat_chk(char *restrict s1, const char *restrict s2, size_t destlen);
#define strcat(a,b) __strcat_chk(a,b,(size_t)-1)
#else /* VARIANT */
#define strcat BUILTIN(strcat)
char *strcat(char *restrict s1, const char *restrict s2);
#endif /* VARIANT */
void strcat_null_dst(char *x) {
strcat(NULL, x); // expected-warning{{Null pointer passed as 1st argument to string concatenation function}}
}
void strcat_null_src(char *x) {
strcat(x, NULL); // expected-warning{{Null pointer passed as 2nd argument to string concatenation function}}
}
void strcat_fn(char *x) {
strcat(x, (char*)&strcat_fn); // expected-warning{{Argument to string concatenation function is the address of the function 'strcat_fn', which is not a null-terminated string}}
}
void strcat_effects(char *y) {
char x[8] = "123";
size_t orig_len = strlen(x);
char a = x[0];
if (strlen(y) != 4)
return;
clang_analyzer_eval(strcat(x, y) == x); // expected-warning{{TRUE}}
clang_analyzer_eval((int)strlen(x) == (orig_len + strlen(y))); // expected-warning{{TRUE}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
void strcat_overflow_0(char *y) {
char x[4] = "12";
if (strlen(y) == 4)
strcat(x, y); // expected-warning{{String concatenation function overflows the destination buffer}}
}
void strcat_overflow_1(char *y) {
char x[4] = "12";
if (strlen(y) == 3)
strcat(x, y); // expected-warning{{String concatenation function overflows the destination buffer}}
}
void strcat_overflow_2(char *y) {
char x[4] = "12";
if (strlen(y) == 2)
strcat(x, y); // expected-warning{{String concatenation function overflows the destination buffer}}
}
#endif
void strcat_no_overflow(char *y) {
char x[5] = "12";
if (strlen(y) == 2)
strcat(x, y); // no-warning
}
void strcat_symbolic_dst_length(char *dst) {
strcat(dst, "1234");
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
}
void strcat_symbolic_dst_length_taint(char *dst) {
scanf("%s", dst); // Taint data.
strcat(dst, "1234");
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
}
void strcat_unknown_src_length(char *src, int offset) {
char dst[8] = "1234";
strcat(dst, &src[offset]);
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
}
// There is no strcat_unknown_dst_length because if we can't get a symbolic
// length for the "before" strlen, we won't be able to set one for "after".
void strcat_too_big(char *dst, char *src) {
// We assume this can never actually happen, so we don't get a warning.
if (strlen(dst) != (((size_t)0) - 2))
return;
if (strlen(src) != 2)
return;
strcat(dst, src);
}
//===----------------------------------------------------------------------===
// strncpy()
//===----------------------------------------------------------------------===
#ifdef VARIANT
#define __strncpy_chk BUILTIN(__strncpy_chk)
char *__strncpy_chk(char *restrict s1, const char *restrict s2, size_t n, size_t destlen);
#define strncpy(a,b,n) __strncpy_chk(a,b,n,(size_t)-1)
#else /* VARIANT */
#define strncpy BUILTIN(strncpy)
char *strncpy(char *restrict s1, const char *restrict s2, size_t n);
#endif /* VARIANT */
void strncpy_null_dst(char *x) {
strncpy(NULL, x, 5); // expected-warning{{Null pointer passed as 1st argument to string copy function}}
}
void strncpy_null_src(char *x) {
strncpy(x, NULL, 5); // expected-warning{{Null pointer passed as 2nd argument to string copy function}}
}
void strncpy_fn(char *x) {
strncpy(x, (char*)&strcpy_fn, 5); // expected-warning{{Argument to string copy function is the address of the function 'strcpy_fn', which is not a null-terminated string}}
}
void strncpy_effects(char *x, char *y) {
char a = x[0];
clang_analyzer_eval(strncpy(x, y, 5) == x); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(x) == strlen(y)); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(a == x[0]); // expected-warning{{UNKNOWN}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
// Enabling the malloc checker enables some of the buffer-checking portions
// of the C-string checker.
void cstringchecker_bounds_nocrash() {
char *p = malloc(2);
strncpy(p, "AAA", sizeof("AAA"));
// expected-warning@-1 {{String copy function overflows the destination buffer}}
free(p);
}
void strncpy_overflow(char *y) {
char x[4];
if (strlen(y) == 4)
strncpy(x, y, 5);
// expected-warning@-1 {{String copy function overflows the destination buffer}}
#ifndef VARIANT
// expected-warning@-3 {{size argument is too large; destination buffer has size 4, but size argument is 5}}
#endif
}
void strncpy_no_overflow(char *y) {
char x[4];
if (strlen(y) == 3)
strncpy(x, y, 5);
// expected-warning@-1 {{String copy function overflows the destination buffer}}
#ifndef VARIANT
// expected-warning@-3 {{size argument is too large; destination buffer has size 4, but size argument is 5}}
#endif
}
void strncpy_no_overflow2(char *y, int n) {
if (n <= 4)
return;
char x[4];
if (strlen(y) == 3)
strncpy(x, y, n);
// expected-warning@-1 {{String copy function overflows the destination buffer}}
}
#endif
void strncpy_truncate(char *y) {
char x[4];
if (strlen(y) == 4)
strncpy(x, y, 3); // no-warning
}
void strncpy_no_truncate(char *y) {
char x[4];
if (strlen(y) == 3)
strncpy(x, y, 3); // no-warning
}
void strncpy_exactly_matching_buffer(char *y) {
char x[4];
strncpy(x, y, 4); // no-warning
// strncpy does not null-terminate, so we have no idea what the strlen is
// after this.
clang_analyzer_eval(strlen(x) > 4); // expected-warning{{UNKNOWN}}
}
void strncpy_zero(char *src) {
char dst[] = "123";
strncpy(dst, src, 0); // no-warning
}
void strncpy_empty() {
char dst[] = "123";
char src[] = "";
strncpy(dst, src, 4); // no-warning
}
//===----------------------------------------------------------------------===
// strncat()
//===----------------------------------------------------------------------===
#ifdef VARIANT
#define __strncat_chk BUILTIN(__strncat_chk)
char *__strncat_chk(char *restrict s1, const char *restrict s2, size_t n, size_t destlen);
#define strncat(a,b,c) __strncat_chk(a,b,c, (size_t)-1)
#else /* VARIANT */
#define strncat BUILTIN(strncat)
char *strncat(char *restrict s1, const char *restrict s2, size_t n);
#endif /* VARIANT */
void strncat_null_dst(char *x) {
strncat(NULL, x, 4); // expected-warning{{Null pointer passed as 1st argument to string concatenation function}}
}
void strncat_null_src(char *x) {
strncat(x, NULL, 4); // expected-warning{{Null pointer passed as 2nd argument to string concatenation function}}
}
void strncat_fn(char *x) {
strncat(x, (char*)&strncat_fn, 4); // expected-warning{{Argument to string concatenation function is the address of the function 'strncat_fn', which is not a null-terminated string}}
}
void strncat_effects(char *y) {
char x[8] = "123";
size_t orig_len = strlen(x);
char a = x[0];
if (strlen(y) != 4)
return;
clang_analyzer_eval(strncat(x, y, strlen(y)) == x); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(x) == (orig_len + strlen(y))); // expected-warning{{TRUE}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
void strncat_overflow_0(char *y) {
char x[4] = "12";
if (strlen(y) == 4)
strncat(x, y, strlen(y));
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
void strncat_overflow_1(char *y) {
char x[4] = "12";
if (strlen(y) == 3)
strncat(x, y, strlen(y));
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
void strncat_overflow_2(char *y) {
char x[4] = "12";
if (strlen(y) == 2)
strncat(x, y, strlen(y));
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
void strncat_overflow_3(char *y) {
char x[4] = "12";
if (strlen(y) == 4)
strncat(x, y, 2);
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
#endif
void strncat_no_overflow_1(char *y) {
char x[5] = "12";
if (strlen(y) == 2)
strncat(x, y, strlen(y)); // no-warning
}
void strncat_no_overflow_2(char *y) {
char x[4] = "12";
if (strlen(y) == 4)
strncat(x, y, 1); // no-warning
}
void strncat_symbolic_dst_length(char *dst) {
strncat(dst, "1234", 5);
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
}
#ifndef SUPPRESS_OUT_OF_BOUND
void strncat_symbolic_src_length(char *src) {
char dst[8] = "1234";
strncat(dst, src, 3);
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
char dst2[8] = "1234";
strncat(dst2, src, 4);
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
void strncat_unknown_src_length(char *src, int offset) {
char dst[8] = "1234";
strncat(dst, &src[offset], 3);
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
char dst2[8] = "1234";
strncat(dst2, &src[offset], 4);
// expected-warning@-1 {{String concatenation function overflows the destination buffer}}
}
#endif
// There is no strncat_unknown_dst_length because if we can't get a symbolic
// length for the "before" strlen, we won't be able to set one for "after".
void strncat_symbolic_limit(unsigned limit) {
char dst[6] = "1234";
char src[] = "567";
strncat(dst, src, limit); // no-warning
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(dst) == 4); // expected-warning{{UNKNOWN}}
}
void strncat_unknown_limit(float limit) {
char dst[6] = "1234";
char src[] = "567";
strncat(dst, src, (size_t)limit); // no-warning
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(dst) == 4); // expected-warning{{UNKNOWN}}
}
void strncat_too_big(char *dst, char *src) {
// We assume this will never actually happen, so we don't get a warning.
if (strlen(dst) != (((size_t)0) - 2))
return;
if (strlen(src) != 2)
return;
strncat(dst, src, 2);
}
void strncat_zero(char *src) {
char dst[] = "123";
strncat(dst, src, 0); // no-warning
}
void strncat_empty() {
char dst[8] = "123";
char src[] = "";
strncat(dst, src, 4); // no-warning
}
//===----------------------------------------------------------------------===
// strcmp()
//===----------------------------------------------------------------------===
#define strcmp BUILTIN(strcmp)
int strcmp(const char * s1, const char * s2);
void strcmp_check_modelling() {
char *x = "aa";
char *y = "a";
clang_analyzer_eval(strcmp(x, y) > 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strcmp(x, y) <= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strcmp(x, y) > 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strcmp(y, x) < 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strcmp(y, x) >= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strcmp(y, x) < -1); // expected-warning{{UNKNOWN}}
}
void strcmp_constant0() {
clang_analyzer_eval(strcmp("123", "123") == 0); // expected-warning{{TRUE}}
}
void strcmp_constant_and_var_0() {
char *x = "123";
clang_analyzer_eval(strcmp(x, "123") == 0); // expected-warning{{TRUE}}
}
void strcmp_constant_and_var_1() {
char *x = "123";
clang_analyzer_eval(strcmp("123", x) == 0); // expected-warning{{TRUE}}
}
void strcmp_0() {
char *x = "123";
char *y = "123";
clang_analyzer_eval(strcmp(x, y) == 0); // expected-warning{{TRUE}}
}
void strcmp_1() {
char *x = "234";
char *y = "123";
clang_analyzer_eval(strcmp(x, y) > 0); // expected-warning{{TRUE}}
}
void strcmp_2() {
char *x = "123";
char *y = "234";
clang_analyzer_eval(strcmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcmp_null_0() {
char *x = NULL;
char *y = "123";
strcmp(x, y); // expected-warning{{Null pointer passed as 1st argument to string comparison function}}
}
void strcmp_null_1() {
char *x = "123";
char *y = NULL;
strcmp(x, y); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
void strcmp_diff_length_0() {
char *x = "12345";
char *y = "234";
clang_analyzer_eval(strcmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcmp_diff_length_1() {
char *x = "123";
char *y = "23456";
clang_analyzer_eval(strcmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcmp_diff_length_2() {
char *x = "12345";
char *y = "123";
clang_analyzer_eval(strcmp(x, y) > 0); // expected-warning{{TRUE}}
}
void strcmp_diff_length_3() {
char *x = "123";
char *y = "12345";
clang_analyzer_eval(strcmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcmp_embedded_null () {
clang_analyzer_eval(strcmp("\0z", "\0y") == 0); // expected-warning{{TRUE}}
}
void strcmp_unknown_arg (char *unknown) {
clang_analyzer_eval(strcmp(unknown, unknown) == 0); // expected-warning{{TRUE}}
}
union argument {
char *f;
};
void function_pointer_cast_helper(char **a) {
strcmp("Hi", *a); // PR24951 crash
}
void strcmp_union_function_pointer_cast(union argument a) {
void (*fPtr)(union argument *) = (void (*)(union argument *))function_pointer_cast_helper;
fPtr(&a);
}
int strcmp_null_argument(char *a) {
char *b = 0;
// Do not warn about the first argument!
return strcmp(a, b); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
//===----------------------------------------------------------------------===
// strncmp()
//===----------------------------------------------------------------------===
#define strncmp BUILTIN(strncmp)
int strncmp(const char *s1, const char *s2, size_t n);
void strncmp_check_modelling() {
char *x = "aa";
char *y = "a";
clang_analyzer_eval(strncmp(x, y, 2) > 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strncmp(x, y, 2) <= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strncmp(x, y, 2) > 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strncmp(y, x, 2) < 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strncmp(y, x, 2) >= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strncmp(y, x, 2) < -1); // expected-warning{{UNKNOWN}}
}
void strncmp_constant0() {
clang_analyzer_eval(strncmp("123", "123", 3) == 0); // expected-warning{{TRUE}}
}
void strncmp_constant_and_var_0() {
char *x = "123";
clang_analyzer_eval(strncmp(x, "123", 3) == 0); // expected-warning{{TRUE}}
}
void strncmp_constant_and_var_1() {
char *x = "123";
clang_analyzer_eval(strncmp("123", x, 3) == 0); // expected-warning{{TRUE}}
}
void strncmp_0() {
char *x = "123";
char *y = "123";
clang_analyzer_eval(strncmp(x, y, 3) == 0); // expected-warning{{TRUE}}
}
void strncmp_1() {
char *x = "234";
char *y = "123";
clang_analyzer_eval(strncmp(x, y, 3) > 0); // expected-warning{{TRUE}}
}
void strncmp_2() {
char *x = "123";
char *y = "234";
clang_analyzer_eval(strncmp(x, y, 3) < 0); // expected-warning{{TRUE}}
}
void strncmp_null_0() {
char *x = NULL;
char *y = "123";
strncmp(x, y, 3); // expected-warning{{Null pointer passed as 1st argument to string comparison function}}
}
void strncmp_null_1() {
char *x = "123";
char *y = NULL;
strncmp(x, y, 3); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
void strncmp_diff_length_0() {
char *x = "12345";
char *y = "234";
clang_analyzer_eval(strncmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_1() {
char *x = "123";
char *y = "23456";
clang_analyzer_eval(strncmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_2() {
char *x = "12345";
char *y = "123";
clang_analyzer_eval(strncmp(x, y, 5) > 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_3() {
char *x = "123";
char *y = "12345";
clang_analyzer_eval(strncmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_4() {
char *x = "123";
char *y = "12345";
clang_analyzer_eval(strncmp(x, y, 3) == 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_5() {
char *x = "012";
char *y = "12345";
clang_analyzer_eval(strncmp(x, y, 3) < 0); // expected-warning{{TRUE}}
}
void strncmp_diff_length_6() {
char *x = "234";
char *y = "12345";
clang_analyzer_eval(strncmp(x, y, 3) > 0); // expected-warning{{TRUE}}
}
void strncmp_embedded_null () {
clang_analyzer_eval(strncmp("ab\0zz", "ab\0yy", 4) == 0); // expected-warning{{TRUE}}
}
int strncmp_null_argument(char *a, size_t n) {
char *b = 0;
// Do not warn about the first argument!
return strncmp(a, b, n); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
//===----------------------------------------------------------------------===
// strcasecmp()
//===----------------------------------------------------------------------===
#define strcasecmp BUILTIN(strcasecmp)
int strcasecmp(const char *s1, const char *s2);
void strcasecmp_check_modelling() {
char *x = "aa";
char *y = "a";
clang_analyzer_eval(strcasecmp(x, y) > 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strcasecmp(x, y) <= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strcasecmp(x, y) > 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strcasecmp(y, x) < 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strcasecmp(y, x) >= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strcasecmp(y, x) < -1); // expected-warning{{UNKNOWN}}
}
void strcasecmp_constant0() {
clang_analyzer_eval(strcasecmp("abc", "Abc") == 0); // expected-warning{{TRUE}}
}
void strcasecmp_constant_and_var_0() {
char *x = "abc";
clang_analyzer_eval(strcasecmp(x, "Abc") == 0); // expected-warning{{TRUE}}
}
void strcasecmp_constant_and_var_1() {
char *x = "abc";
clang_analyzer_eval(strcasecmp("Abc", x) == 0); // expected-warning{{TRUE}}
}
void strcasecmp_0() {
char *x = "abc";
char *y = "Abc";
clang_analyzer_eval(strcasecmp(x, y) == 0); // expected-warning{{TRUE}}
}
void strcasecmp_1() {
char *x = "Bcd";
char *y = "abc";
clang_analyzer_eval(strcasecmp(x, y) > 0); // expected-warning{{TRUE}}
}
void strcasecmp_2() {
char *x = "abc";
char *y = "Bcd";
clang_analyzer_eval(strcasecmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcasecmp_null_0() {
char *x = NULL;
char *y = "123";
strcasecmp(x, y); // expected-warning{{Null pointer passed as 1st argument to string comparison function}}
}
void strcasecmp_null_1() {
char *x = "123";
char *y = NULL;
strcasecmp(x, y); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
void strcasecmp_diff_length_0() {
char *x = "abcde";
char *y = "aBd";
clang_analyzer_eval(strcasecmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcasecmp_diff_length_1() {
char *x = "abc";
char *y = "aBdef";
clang_analyzer_eval(strcasecmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcasecmp_diff_length_2() {
char *x = "aBcDe";
char *y = "abc";
clang_analyzer_eval(strcasecmp(x, y) > 0); // expected-warning{{TRUE}}
}
void strcasecmp_diff_length_3() {
char *x = "aBc";
char *y = "abcde";
clang_analyzer_eval(strcasecmp(x, y) < 0); // expected-warning{{TRUE}}
}
void strcasecmp_embedded_null () {
clang_analyzer_eval(strcasecmp("ab\0zz", "ab\0yy") == 0); // expected-warning{{TRUE}}
}
int strcasecmp_null_argument(char *a) {
char *b = 0;
// Do not warn about the first argument!
return strcasecmp(a, b); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
//===----------------------------------------------------------------------===
// strncasecmp()
//===----------------------------------------------------------------------===
#define strncasecmp BUILTIN(strncasecmp)
int strncasecmp(const char *s1, const char *s2, size_t n);
void strncasecmp_check_modelling() {
char *x = "aa";
char *y = "a";
clang_analyzer_eval(strncasecmp(x, y, 2) > 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strncasecmp(x, y, 2) <= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strncasecmp(x, y, 2) > 1); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strncasecmp(y, x, 2) < 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strncasecmp(y, x, 2) >= 0); // expected-warning{{FALSE}}
clang_analyzer_eval(strncasecmp(y, x, 2) < -1); // expected-warning{{UNKNOWN}}
}
void strncasecmp_constant0() {
clang_analyzer_eval(strncasecmp("abc", "Abc", 3) == 0); // expected-warning{{TRUE}}
}
void strncasecmp_constant_and_var_0() {
char *x = "abc";
clang_analyzer_eval(strncasecmp(x, "Abc", 3) == 0); // expected-warning{{TRUE}}
}
void strncasecmp_constant_and_var_1() {
char *x = "abc";
clang_analyzer_eval(strncasecmp("Abc", x, 3) == 0); // expected-warning{{TRUE}}
}
void strncasecmp_0() {
char *x = "abc";
char *y = "Abc";
clang_analyzer_eval(strncasecmp(x, y, 3) == 0); // expected-warning{{TRUE}}
}
void strncasecmp_1() {
char *x = "Bcd";
char *y = "abc";
clang_analyzer_eval(strncasecmp(x, y, 3) > 0); // expected-warning{{TRUE}}
}
void strncasecmp_2() {
char *x = "abc";
char *y = "Bcd";
clang_analyzer_eval(strncasecmp(x, y, 3) < 0); // expected-warning{{TRUE}}
}
void strncasecmp_null_0() {
char *x = NULL;
char *y = "123";
strncasecmp(x, y, 3); // expected-warning{{Null pointer passed as 1st argument to string comparison function}}
}
void strncasecmp_null_1() {
char *x = "123";
char *y = NULL;
strncasecmp(x, y, 3); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
void strncasecmp_diff_length_0() {
char *x = "abcde";
char *y = "aBd";
clang_analyzer_eval(strncasecmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_1() {
char *x = "abc";
char *y = "aBdef";
clang_analyzer_eval(strncasecmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_2() {
char *x = "aBcDe";
char *y = "abc";
clang_analyzer_eval(strncasecmp(x, y, 5) > 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_3() {
char *x = "aBc";
char *y = "abcde";
clang_analyzer_eval(strncasecmp(x, y, 5) < 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_4() {
char *x = "abcde";
char *y = "aBc";
clang_analyzer_eval(strncasecmp(x, y, 3) == 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_5() {
char *x = "abcde";
char *y = "aBd";
clang_analyzer_eval(strncasecmp(x, y, 3) < 0); // expected-warning{{TRUE}}
}
void strncasecmp_diff_length_6() {
char *x = "aBDe";
char *y = "abc";
clang_analyzer_eval(strncasecmp(x, y, 3) > 0); // expected-warning{{TRUE}}
}
void strncasecmp_embedded_null () {
clang_analyzer_eval(strncasecmp("ab\0zz", "ab\0yy", 4) == 0); // expected-warning{{TRUE}}
}
int strncasecmp_null_argument(char *a, size_t n) {
char *b = 0;
// Do not warn about the first argument!
return strncasecmp(a, b, n); // expected-warning{{Null pointer passed as 2nd argument to string comparison function}}
}
//===----------------------------------------------------------------------===
// strsep()
//===----------------------------------------------------------------------===
char *strsep(char **stringp, const char *delim);
void strsep_null_delim(char *s) {
strsep(&s, NULL); // expected-warning{{Null pointer passed as 2nd argument to strsep()}}
}
void strsep_null_search() {
strsep(NULL, ""); // expected-warning{{Null pointer passed as 1st argument to strsep()}}
}
void strsep_return_original_pointer(char *s) {
char *original = s;
char *result = strsep(&s, ""); // no-warning
clang_analyzer_eval(original == result); // expected-warning{{TRUE}}
}
void strsep_null_string() {
char *s = NULL;
char *result = strsep(&s, ""); // no-warning
clang_analyzer_eval(result == NULL); // expected-warning{{TRUE}}
}
void strsep_changes_input_pointer(char *s) {
char *original = s;
strsep(&s, ""); // no-warning
clang_analyzer_eval(s == original); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(s == NULL); // expected-warning{{UNKNOWN}}
// Check that the value is symbolic.
if (s == NULL) {
clang_analyzer_eval(s == NULL); // expected-warning{{TRUE}}
}
}
void strsep_changes_input_string() {
char str[] = "abc";
clang_analyzer_eval(str[1] == 'b'); // expected-warning{{TRUE}}
char *s = str;
strsep(&s, "b"); // no-warning
// The real strsep will change the first delimiter it finds into a NUL
// character. For now, we just model the invalidation.
clang_analyzer_eval(str[1] == 'b'); // expected-warning{{UNKNOWN}}
}
//===----------------------------------------------------------------------===
// memset() / explicit_bzero() / bzero()
//===----------------------------------------------------------------------===
void *memset(void *dest, int ch, size_t count);
void bzero(void *dst, size_t count);
void explicit_bzero(void *dest, size_t count);
void *malloc(size_t size);
void free(void *);
void memset1_char_array_null() {
char str[] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
memset(str, '\0', 2);
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
}
void memset2_char_array_null() {
char str[] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
memset(str, '\0', strlen(str) + 1);
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(str[2] == 0); // expected-warning{{TRUE}}
}
void memset3_char_malloc_null() {
char *str = (char *)malloc(10 * sizeof(char));
memset(str + 1, '\0', 8);
clang_analyzer_eval(str[1] == 0); // expected-warning{{UNKNOWN}}
free(str);
}
void memset4_char_malloc_null() {
char *str = (char *)malloc(10 * sizeof(char));
//void *str = malloc(10 * sizeof(char));
memset(str, '\0', 10);
clang_analyzer_eval(str[1] == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
free(str);
}
#ifdef SUPPRESS_OUT_OF_BOUND
void memset5_char_malloc_overflow_null() {
char *str = (char *)malloc(10 * sizeof(char));
memset(str, '\0', 12);
clang_analyzer_eval(str[1] == 0); // expected-warning{{UNKNOWN}}
free(str);
}
#endif
void memset6_char_array_nonnull() {
char str[] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
memset(str, '0', 2);
clang_analyzer_eval(str[0] == 'a'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{UNKNOWN}}
}
#ifdef SUPPRESS_OUT_OF_BOUND
void memset8_char_array_nonnull() {
char str[5] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
memset(str, '0', 10); // expected-warning{{'memset' will always overflow; destination buffer has size 5, but size argument is 10}}
clang_analyzer_eval(str[0] != '0'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen(str) >= 10); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) < 10); // expected-warning{{FALSE}}
}
#endif
struct POD_memset {
int num;
char c;
};
void memset10_struct() {
struct POD_memset pod;
char *str = (char *)&pod;
pod.num = 1;
pod.c = 1;
clang_analyzer_eval(pod.num == 0); // expected-warning{{FALSE}}
memset(str, 0, sizeof(struct POD_memset));
clang_analyzer_eval(pod.num == 0); // expected-warning{{TRUE}}
}
#ifdef SUPPRESS_OUT_OF_BOUND
void memset11_struct_field() {
struct POD_memset pod;
pod.num = 1;
pod.c = '1';
memset(&pod.num, 0, sizeof(struct POD_memset));
clang_analyzer_eval(pod.num == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(pod.c == '\0'); // expected-warning{{TRUE}}
}
void memset12_struct_field() {
struct POD_memset pod;
pod.num = 1;
pod.c = '1';
memset(&pod.c, 0, sizeof(struct POD_memset)); // expected-warning {{'memset' will always overflow; destination buffer has size 4, but size argument is 8}}
clang_analyzer_eval(pod.num == 0); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(pod.c == 0); // expected-warning{{UNKNOWN}}
}
union U_memset {
int i;
double d;
char c;
};
void memset13_union_field() {
union U_memset u;
u.i = 5;
memset(&u.i, '\0', sizeof(union U_memset));
// Note: This should be TRUE, analyzer can't handle union perfectly now.
clang_analyzer_eval(u.d == 0); // expected-warning{{UNKNOWN}}
}
#endif
void memset14_region_cast() {
char *str = (char *)malloc(10 * sizeof(int));
int *array = (int *)str;
memset(array, 0, 10 * sizeof(int));
clang_analyzer_eval(str[10] == '\0'); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen((char *)array) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
free(str);
}
void memset15_region_cast() {
char *str = (char *)malloc(10 * sizeof(int));
int *array = (int *)str;
memset(array, 0, 5 * sizeof(int));
clang_analyzer_eval(str[10] == '\0'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen((char *)array) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
free(str);
}
int memset20_scalar() {
int *x = malloc(sizeof(int));
*x = 10;
memset(x, 0, sizeof(int));
int num = 1 / *x; // expected-warning{{Division by zero}}
free(x);
return num;
}
int memset21_scalar() {
int *x = malloc(sizeof(int));
memset(x, 0, 1);
int num = 1 / *x;
free(x);
return num;
}
void memset22_array() {
int array[] = {1, 2, 3, 4, 5, 6, 7, 8, 9};
clang_analyzer_eval(array[1] == 2); // expected-warning{{TRUE}}
memset(array, 0, sizeof(array));
clang_analyzer_eval(array[1] == 0); // expected-warning{{TRUE}}
}
void memset23_array_pod_object() {
struct POD_memset array[10];
array[1].num = 10;
array[1].c = 'c';
clang_analyzer_eval(array[1].num == 10); // expected-warning{{TRUE}}
memset(&array[1], 0, sizeof(struct POD_memset));
clang_analyzer_eval(array[1].num == 0); // expected-warning{{UNKNOWN}}
}
void memset24_array_pod_object() {
struct POD_memset array[10];
array[1].num = 10;
array[1].c = 'c';
clang_analyzer_eval(array[1].num == 10); // expected-warning{{TRUE}}
memset(array, 0, sizeof(array));
clang_analyzer_eval(array[1].num == 0); // expected-warning{{TRUE}}
}
void memset25_symbol(char c) {
char array[10] = {1};
if (c != 0)
return;
memset(array, c, 10);
clang_analyzer_eval(strlen(array) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(array[4] == 0); // expected-warning{{TRUE}}
}
void memset26_upper_UCHAR_MAX() {
char array[10] = {1};
memset(array, 1024, 10);
clang_analyzer_eval(strlen(array) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(array[4] == 0); // expected-warning{{TRUE}}
}
void bzero1_null() {
char *a = NULL;
bzero(a, 10); // expected-warning{{Null pointer passed as 1st argument to memory clearance function}}
}
void bzero2_char_array_null() {
char str[] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
bzero(str, 2);
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{TRUE}}
}
void bzero3_char_ptr_null() {
char *str = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
bzero(str + 2, 2);
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{FALSE}}
}
void explicit_bzero1_null() {
char *a = NULL;
explicit_bzero(a, 10); // expected-warning{{Null pointer passed as 1st argument to memory clearance function}}
}
void explicit_bzero2_clear_mypassword() {
char passwd[7] = "passwd";
explicit_bzero(passwd, sizeof(passwd)); // no-warning
clang_analyzer_eval(strlen(passwd) == 0); // expected-warning{{TRUE}}
clang_analyzer_eval(passwd[0] == '\0'); // expected-warning{{TRUE}}
}
void explicit_bzero3_out_ofbound() {
char *privkey = (char *)malloc(7);
const char newprivkey[10] = "mysafekey";
strcpy(privkey, "random");
explicit_bzero(privkey, sizeof(newprivkey));
#ifndef SUPPRESS_OUT_OF_BOUND
// expected-warning@-2 {{Memory clearance function overflows the destination buffer}}
#endif
clang_analyzer_eval(privkey[0] == '\0');
#ifdef SUPPRESS_OUT_OF_BOUND
// expected-warning@-2 {{UNKNOWN}}
#endif
free(privkey);
}
//===----------------------------------------------------------------------===
// FIXMEs
//===----------------------------------------------------------------------===
// The analyzer_eval call below should evaluate to true. We are being too
// aggressive in marking the (length of) src symbol dead. The length of dst
// depends on src. This could be explicitly specified in the checker or the
// logic for handling MetadataSymbol in SymbolManager needs to change.
void strcat_symbolic_src_length(char *src) {
char dst[8] = "1234";
strcat(dst, src);
clang_analyzer_eval(strlen(dst) >= 4); // expected-warning{{UNKNOWN}}
}
// The analyzer_eval call below should evaluate to true. Most likely the same
// issue as the test above.
void strncpy_exactly_matching_buffer2(char *y) {
if (strlen(y) >= 4)
return;
char x[4];
strncpy(x, y, 4); // no-warning
// This time, we know that y fits in x anyway.
clang_analyzer_eval(strlen(x) <= 3); // expected-warning{{UNKNOWN}}
}
void memset7_char_array_nonnull() {
char str[5] = "abcd";
clang_analyzer_eval(strlen(str) == 4); // expected-warning{{TRUE}}
memset(str, '0', 5);
// FIXME: This should be TRUE.
clang_analyzer_eval(str[0] == '0'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen(str) >= 5); // expected-warning{{TRUE}}
}
void memset16_region_cast() {
char *str = (char *)malloc(10 * sizeof(int));
int *array = (int *)str;
memset(array, '0', 10 * sizeof(int));
// FIXME: This should be TRUE.
clang_analyzer_eval(str[10] == '0'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen((char *)array) >= 10 * sizeof(int)); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) >= 10 * sizeof(int)); // expected-warning{{TRUE}}
free(str);
}
#ifdef SUPPRESS_OUT_OF_BOUND
void memset17_region_cast() {
char *str = (char *)malloc(10 * sizeof(int));
int *array = (int *)str;
memset(array, '0', 12 * sizeof(int));
clang_analyzer_eval(str[10] == '0'); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(strlen((char *)array) >= 12 * sizeof(int)); // expected-warning{{TRUE}}
clang_analyzer_eval(strlen(str) >= 12 * sizeof(int)); // expected-warning{{TRUE}}
free(str);
}
void memset18_memset_multiple_times() {
char *str = (char *)malloc(10 * sizeof(char));
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}}
memset(str + 2, '\0', 10 * sizeof(char));
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(str[1] == '\0'); // expected-warning{{UNKNOWN}}
memset(str, '0', 10 * sizeof(char));
clang_analyzer_eval(strlen(str) >= 10); // expected-warning{{TRUE}}
// FIXME: This should be TRUE.
clang_analyzer_eval(str[1] == '0'); // expected-warning{{UNKNOWN}}
free(str);
}
void memset19_memset_multiple_times() {
char *str = (char *)malloc(10 * sizeof(char));
clang_analyzer_eval(strlen(str) == 0); // expected-warning{{UNKNOWN}}
memset(str, '0', 10 * sizeof(char));
clang_analyzer_eval(strlen(str) >= 10); // expected-warning{{TRUE}}
// FIXME: This should be TRUE.
clang_analyzer_eval(str[1] == '0'); // expected-warning{{UNKNOWN}}
memset(str + 2, '\0', 10 * sizeof(char));
clang_analyzer_eval(strlen(str) >= 10); // expected-warning{{UNKNOWN}}
clang_analyzer_eval(str[1] == '0'); // expected-warning{{UNKNOWN}}
free(str);
}
#endif
// The analyzer does not support binding a symbol with default binding.
void memset27_symbol(char c) {
char array[10] = {0};
if (c < 10)
return;
memset(array, c, 10);
clang_analyzer_eval(strlen(array) >= 10); // expected-warning{{TRUE}}
// FIXME: This should be TRUE.
clang_analyzer_eval(array[4] >= 10); // expected-warning{{UNKNOWN}}
}
void memset28() {
short x;
memset(&x, 1, sizeof(short));
// This should be true.
clang_analyzer_eval(x == 0x101); // expected-warning{{UNKNOWN}}
}
void memset29_plain_int_zero() {
short x;
memset(&x, 0, sizeof(short));
clang_analyzer_eval(x == 0); // expected-warning{{TRUE}}
}
void test_memset_chk() {
int x;
__builtin___memset_chk(&x, 0, sizeof(x), __builtin_object_size(&x, 0));
clang_analyzer_eval(x == 0); // expected-warning{{TRUE}}
}