cxx-uninitialized-object-unguarded-access.cpp
7.73 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
// RUN: %clang_analyze_cc1 -analyzer-checker=core,optin.cplusplus.UninitializedObject \
// RUN: -analyzer-config optin.cplusplus.UninitializedObject:Pedantic=true -DPEDANTIC \
// RUN: -analyzer-config optin.cplusplus.UninitializedObject:IgnoreGuardedFields=true \
// RUN: -std=c++11 -verify %s
//===----------------------------------------------------------------------===//
// Helper functions for tests.
//===----------------------------------------------------------------------===//
[[noreturn]] void halt();
void assert(int b) {
if (!b)
halt();
}
int rand();
//===----------------------------------------------------------------------===//
// Tests for fields properly guarded by asserts.
//===----------------------------------------------------------------------===//
class NoUnguardedFieldsTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
NoUnguardedFieldsTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
assert(K == Kind::A);
(void)Area;
}
void operator+() {
assert(K == Kind::V);
(void)Volume;
}
};
void fNoUnguardedFieldsTest() {
NoUnguardedFieldsTest T1(NoUnguardedFieldsTest::Kind::A);
NoUnguardedFieldsTest T2(NoUnguardedFieldsTest::Kind::V);
}
class NoUngardedFieldsNoReturnFuncCalledTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
NoUngardedFieldsNoReturnFuncCalledTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
halt();
(void)Area;
}
void operator+() {
halt();
(void)Volume;
}
};
void fNoUngardedFieldsNoReturnFuncCalledTest() {
NoUngardedFieldsNoReturnFuncCalledTest
T1(NoUngardedFieldsNoReturnFuncCalledTest::Kind::A);
NoUngardedFieldsNoReturnFuncCalledTest
T2(NoUngardedFieldsNoReturnFuncCalledTest::Kind::V);
}
class NoUnguardedFieldsWithUndefMethodTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
NoUnguardedFieldsWithUndefMethodTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
assert(K == Kind::A);
(void)Area;
}
void operator+() {
assert(K == Kind::V);
(void)Volume;
}
// We're checking method definitions for guards, so this is a no-crash test
// whether we handle methods without definitions.
void methodWithoutDefinition();
};
void fNoUnguardedFieldsWithUndefMethodTest() {
NoUnguardedFieldsWithUndefMethodTest
T1(NoUnguardedFieldsWithUndefMethodTest::Kind::A);
NoUnguardedFieldsWithUndefMethodTest
T2(NoUnguardedFieldsWithUndefMethodTest::Kind::V);
}
class UnguardedFieldThroughMethodTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area; // expected-note {{uninitialized field 'this->Volume'}}
Kind K;
public:
UnguardedFieldThroughMethodTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0; // expected-warning {{1 uninitialized field}}
break;
}
}
void operator-() {
assert(K == Kind::A);
(void)Area;
}
void operator+() {
(void)Volume;
}
};
void fUnguardedFieldThroughMethodTest() {
UnguardedFieldThroughMethodTest T1(UnguardedFieldThroughMethodTest::Kind::A);
}
class UnguardedPublicFieldsTest {
public:
enum Kind {
V,
A
};
public:
// Note that fields are public.
int Volume, Area; // expected-note {{uninitialized field 'this->Volume'}}
Kind K;
public:
UnguardedPublicFieldsTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0; // expected-warning {{1 uninitialized field}}
break;
}
}
void operator-() {
assert(K == Kind::A);
(void)Area;
}
void operator+() {
assert(K == Kind::V);
(void)Volume;
}
};
void fUnguardedPublicFieldsTest() {
UnguardedPublicFieldsTest T1(UnguardedPublicFieldsTest::Kind::A);
}
//===----------------------------------------------------------------------===//
// Highlights of some false negatives due to syntactic checking.
//===----------------------------------------------------------------------===//
class UnguardedFalseNegativeTest1 {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
UnguardedFalseNegativeTest1(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
if (rand())
assert(K == Kind::A);
(void)Area;
}
void operator+() {
if (rand())
assert(K == Kind::V);
(void)Volume;
}
};
void fUnguardedFalseNegativeTest1() {
UnguardedFalseNegativeTest1 T1(UnguardedFalseNegativeTest1::Kind::A);
}
class UnguardedFalseNegativeTest2 {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
UnguardedFalseNegativeTest2(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
assert(rand());
(void)Area;
}
void operator+() {
assert(rand());
(void)Volume;
}
};
void fUnguardedFalseNegativeTest2() {
UnguardedFalseNegativeTest2 T1(UnguardedFalseNegativeTest2::Kind::A);
}
//===----------------------------------------------------------------------===//
// Tests for other guards. These won't be as thorough, as other guards are
// matched the same way as asserts, so if they are recognized, they are expected
// to work as well as asserts do.
//
// None of these tests expect warnings, since the flag works correctly if these
// fields are regarded properly guarded.
//===----------------------------------------------------------------------===//
class IfGuardedFieldsTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
IfGuardedFieldsTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
void operator-() {
if (K != Kind::A)
return;
(void)Area;
}
void operator+() {
if (K != Kind::V)
return;
(void)Volume;
}
};
void fIfGuardedFieldsTest() {
IfGuardedFieldsTest T1(IfGuardedFieldsTest::Kind::A);
IfGuardedFieldsTest T2(IfGuardedFieldsTest::Kind::V);
}
class SwitchGuardedFieldsTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
SwitchGuardedFieldsTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
int operator-() {
switch (K) {
case Kind::A:
return Area;
case Kind::V:
return -1;
}
}
int operator+() {
switch (K) {
case Kind::A:
return Area;
case Kind::V:
return -1;
}
}
};
void fSwitchGuardedFieldsTest() {
SwitchGuardedFieldsTest T1(SwitchGuardedFieldsTest::Kind::A);
SwitchGuardedFieldsTest T2(SwitchGuardedFieldsTest::Kind::V);
}
class ConditionalOperatorGuardedFieldsTest {
public:
enum Kind {
V,
A
};
private:
int Volume, Area;
Kind K;
public:
ConditionalOperatorGuardedFieldsTest(Kind K) : K(K) {
switch (K) {
case V:
Volume = 0;
break;
case A:
Area = 0;
break;
}
}
int operator-() {
return K == Kind::A ? Area : -1;
}
int operator+() {
return K == Kind::V ? Volume : -1;
}
};
void fConditionalOperatorGuardedFieldsTest() {
ConditionalOperatorGuardedFieldsTest
T1(ConditionalOperatorGuardedFieldsTest::Kind::A);
ConditionalOperatorGuardedFieldsTest
T2(ConditionalOperatorGuardedFieldsTest::Kind::V);
}