OverlappingReplacementsTest.cpp
11 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
//===---- OverlappingReplacementsTest.cpp - clang-tidy --------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "ClangTidyTest.h"
#include "clang/AST/RecursiveASTVisitor.h"
#include "gtest/gtest.h"
namespace clang {
namespace tidy {
namespace test {
namespace {
const char BoundDecl[] = "decl";
const char BoundIf[] = "if";
// We define a reduced set of very small checks that allow to test different
// overlapping situations (no overlapping, replacements partially overlap, etc),
// as well as different kinds of diagnostics (one check produces several errors,
// several replacement ranges in an error, etc).
class UseCharCheck : public ClangTidyCheck {
public:
UseCharCheck(StringRef CheckName, ClangTidyContext *Context)
: ClangTidyCheck(CheckName, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override {
using namespace ast_matchers;
Finder->addMatcher(varDecl(hasType(isInteger())).bind(BoundDecl), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) override {
auto *VD = Result.Nodes.getNodeAs<VarDecl>(BoundDecl);
diag(VD->getBeginLoc(), "use char") << FixItHint::CreateReplacement(
CharSourceRange::getTokenRange(VD->getBeginLoc(), VD->getBeginLoc()),
"char");
}
};
class IfFalseCheck : public ClangTidyCheck {
public:
IfFalseCheck(StringRef CheckName, ClangTidyContext *Context)
: ClangTidyCheck(CheckName, Context) {}
void registerMatchers(ast_matchers::MatchFinder *Finder) override {
using namespace ast_matchers;
Finder->addMatcher(ifStmt().bind(BoundIf), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) override {
auto *If = Result.Nodes.getNodeAs<IfStmt>(BoundIf);
auto *Cond = If->getCond();
SourceRange Range = Cond->getSourceRange();
if (auto *D = If->getConditionVariable()) {
Range = SourceRange(D->getBeginLoc(), D->getEndLoc());
}
diag(Range.getBegin(), "the cake is a lie") << FixItHint::CreateReplacement(
CharSourceRange::getTokenRange(Range), "false");
}
};
class RefactorCheck : public ClangTidyCheck {
public:
RefactorCheck(StringRef CheckName, ClangTidyContext *Context)
: ClangTidyCheck(CheckName, Context), NamePattern("::$") {}
RefactorCheck(StringRef CheckName, ClangTidyContext *Context,
StringRef NamePattern)
: ClangTidyCheck(CheckName, Context), NamePattern(NamePattern) {}
virtual std::string newName(StringRef OldName) = 0;
void registerMatchers(ast_matchers::MatchFinder *Finder) final {
using namespace ast_matchers;
Finder->addMatcher(varDecl(matchesName(NamePattern)).bind(BoundDecl), this);
}
void check(const ast_matchers::MatchFinder::MatchResult &Result) final {
auto *VD = Result.Nodes.getNodeAs<VarDecl>(BoundDecl);
std::string NewName = newName(VD->getName());
auto Diag = diag(VD->getLocation(), "refactor %0 into %1")
<< VD->getName() << NewName
<< FixItHint::CreateReplacement(
CharSourceRange::getTokenRange(VD->getLocation(),
VD->getLocation()),
NewName);
class UsageVisitor : public RecursiveASTVisitor<UsageVisitor> {
public:
UsageVisitor(const ValueDecl *VD, StringRef NewName,
DiagnosticBuilder &Diag)
: VD(VD), NewName(NewName), Diag(Diag) {}
bool VisitDeclRefExpr(DeclRefExpr *E) {
if (const ValueDecl *D = E->getDecl()) {
if (VD->getCanonicalDecl() == D->getCanonicalDecl()) {
Diag << FixItHint::CreateReplacement(
CharSourceRange::getTokenRange(E->getSourceRange()), NewName);
}
}
return RecursiveASTVisitor<UsageVisitor>::VisitDeclRefExpr(E);
}
private:
const ValueDecl *VD;
StringRef NewName;
DiagnosticBuilder &Diag;
};
UsageVisitor(VD, NewName, Diag)
.TraverseDecl(Result.Context->getTranslationUnitDecl());
}
protected:
const std::string NamePattern;
};
class StartsWithPotaCheck : public RefactorCheck {
public:
StartsWithPotaCheck(StringRef CheckName, ClangTidyContext *Context)
: RefactorCheck(CheckName, Context, "::pota") {}
std::string newName(StringRef OldName) override {
return "toma" + OldName.substr(4).str();
}
};
class EndsWithTatoCheck : public RefactorCheck {
public:
EndsWithTatoCheck(StringRef CheckName, ClangTidyContext *Context)
: RefactorCheck(CheckName, Context, "tato$") {}
std::string newName(StringRef OldName) override {
return OldName.substr(0, OldName.size() - 4).str() + "melo";
}
};
} // namespace
TEST(OverlappingReplacementsTest, UseCharCheckTest) {
const char Code[] =
R"(void f() {
int a = 0;
if (int b = 0) {
int c = a;
}
})";
const char CharFix[] =
R"(void f() {
char a = 0;
if (char b = 0) {
char c = a;
}
})";
EXPECT_EQ(CharFix, runCheckOnCode<UseCharCheck>(Code));
}
TEST(OverlappingReplacementsTest, IfFalseCheckTest) {
const char Code[] =
R"(void f() {
int potato = 0;
if (int b = 0) {
int c = potato;
} else if (true) {
int d = 0;
}
})";
const char IfFix[] =
R"(void f() {
int potato = 0;
if (false) {
int c = potato;
} else if (false) {
int d = 0;
}
})";
EXPECT_EQ(IfFix, runCheckOnCode<IfFalseCheck>(Code));
}
TEST(OverlappingReplacementsTest, StartsWithCheckTest) {
const char Code[] =
R"(void f() {
int a = 0;
int potato = 0;
if (int b = 0) {
int c = potato;
} else if (true) {
int d = 0;
}
})";
const char StartsFix[] =
R"(void f() {
int a = 0;
int tomato = 0;
if (int b = 0) {
int c = tomato;
} else if (true) {
int d = 0;
}
})";
EXPECT_EQ(StartsFix, runCheckOnCode<StartsWithPotaCheck>(Code));
}
TEST(OverlappingReplacementsTest, EndsWithCheckTest) {
const char Code[] =
R"(void f() {
int a = 0;
int potato = 0;
if (int b = 0) {
int c = potato;
} else if (true) {
int d = 0;
}
})";
const char EndsFix[] =
R"(void f() {
int a = 0;
int pomelo = 0;
if (int b = 0) {
int c = pomelo;
} else if (true) {
int d = 0;
}
})";
EXPECT_EQ(EndsFix, runCheckOnCode<EndsWithTatoCheck>(Code));
}
TEST(OverlappingReplacementTest, ReplacementsDoNotOverlap) {
std::string Res;
const char Code[] =
R"(void f() {
int potassium = 0;
if (true) {
int Potato = potassium;
}
})";
const char CharIfFix[] =
R"(void f() {
char potassium = 0;
if (false) {
char Potato = potassium;
}
})";
Res = runCheckOnCode<UseCharCheck, IfFalseCheck>(Code);
EXPECT_EQ(CharIfFix, Res);
const char StartsEndsFix[] =
R"(void f() {
int tomassium = 0;
if (true) {
int Pomelo = tomassium;
}
})";
Res = runCheckOnCode<StartsWithPotaCheck, EndsWithTatoCheck>(Code);
EXPECT_EQ(StartsEndsFix, Res);
const char CharIfStartsEndsFix[] =
R"(void f() {
char tomassium = 0;
if (false) {
char Pomelo = tomassium;
}
})";
Res = runCheckOnCode<UseCharCheck, IfFalseCheck, StartsWithPotaCheck,
EndsWithTatoCheck>(Code);
EXPECT_EQ(CharIfStartsEndsFix, Res);
}
TEST(OverlappingReplacementsTest, ReplacementInsideOtherReplacement) {
std::string Res;
const char Code[] =
R"(void f() {
if (char potato = 0) {
} else if (int a = 0) {
char potato = 0;
if (potato) potato;
}
})";
// Apply the UseCharCheck together with the IfFalseCheck.
//
// The 'If' fix contains the other, so that is the one that has to be applied.
// } else if (int a = 0) {
// ^^^ -> char
// ~~~~~~~~~ -> false
const char CharIfFix[] =
R"(void f() {
if (false) {
} else if (false) {
char potato = 0;
if (false) potato;
}
})";
Res = runCheckOnCode<UseCharCheck, IfFalseCheck>(Code);
EXPECT_EQ(CharIfFix, Res);
Res = runCheckOnCode<IfFalseCheck, UseCharCheck>(Code);
EXPECT_EQ(CharIfFix, Res);
// Apply the IfFalseCheck with the StartsWithPotaCheck.
//
// The 'If' replacement is bigger here.
// if (char potato = 0) {
// ^^^^^^ -> tomato
// ~~~~~~~~~~~~~~~ -> false
//
// But the refactoring is the one that contains the other here:
// char potato = 0;
// ^^^^^^ -> tomato
// if (potato) potato;
// ^^^^^^ ^^^^^^ -> tomato, tomato
// ~~~~~~ -> false
const char IfStartsFix[] =
R"(void f() {
if (false) {
} else if (false) {
char tomato = 0;
if (tomato) tomato;
}
})";
Res = runCheckOnCode<IfFalseCheck, StartsWithPotaCheck>(Code);
EXPECT_EQ(IfStartsFix, Res);
Res = runCheckOnCode<StartsWithPotaCheck, IfFalseCheck>(Code);
EXPECT_EQ(IfStartsFix, Res);
}
TEST(OverlappingReplacements, TwoReplacementsInsideOne) {
std::string Res;
const char Code[] =
R"(void f() {
if (int potato = 0) {
int a = 0;
}
})";
// The two smallest replacements should not be applied.
// if (int potato = 0) {
// ^^^^^^ -> tomato
// *** -> char
// ~~~~~~~~~~~~~~ -> false
// But other errors from the same checks should not be affected.
// int a = 0;
// *** -> char
const char Fix[] =
R"(void f() {
if (false) {
char a = 0;
}
})";
Res = runCheckOnCode<UseCharCheck, IfFalseCheck, StartsWithPotaCheck>(Code);
EXPECT_EQ(Fix, Res);
Res = runCheckOnCode<StartsWithPotaCheck, IfFalseCheck, UseCharCheck>(Code);
EXPECT_EQ(Fix, Res);
}
TEST(OverlappingReplacementsTest,
ApplyAtMostOneOfTheChangesWhenPartialOverlapping) {
std::string Res;
const char Code[] =
R"(void f() {
if (int potato = 0) {
int a = potato;
}
})";
// These two replacements overlap, but none of them is completely contained
// inside the other.
// if (int potato = 0) {
// ^^^^^^ -> tomato
// ~~~~~~~~~~~~~~ -> false
// int a = potato;
// ^^^^^^ -> tomato
//
// The 'StartsWithPotaCheck' fix has endpoints inside the 'IfFalseCheck' fix,
// so it is going to be set as inapplicable. The 'if' fix will be applied.
const char IfFix[] =
R"(void f() {
if (false) {
int a = potato;
}
})";
Res = runCheckOnCode<IfFalseCheck, StartsWithPotaCheck>(Code);
EXPECT_EQ(IfFix, Res);
}
TEST(OverlappingReplacementsTest, TwoErrorsHavePerfectOverlapping) {
std::string Res;
const char Code[] =
R"(void f() {
int potato = 0;
potato += potato * potato;
if (char a = potato) potato;
})";
// StartsWithPotaCheck will try to refactor 'potato' into 'tomato', and
// EndsWithTatoCheck will try to use 'pomelo'. Both fixes have the same set of
// ranges. This is a corner case of one error completely containing another:
// the other completely contains the first one as well. Both errors are
// discarded.
Res = runCheckOnCode<StartsWithPotaCheck, EndsWithTatoCheck>(Code);
EXPECT_EQ(Code, Res);
}
} // namespace test
} // namespace tidy
} // namespace clang