bugprone-too-small-loop-variable.cpp
8.03 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
// RUN: %check_clang_tidy %s bugprone-too-small-loop-variable %t -- \
// RUN: -config="{CheckOptions: \
// RUN: [{key: bugprone-too-small-loop-variable.MagnitudeBitsUpperLimit, \
// RUN: value: 1024}]}" \
// RUN: -- --target=x86_64-linux
long size() { return 294967296l; }
////////////////////////////////////////////////////////////////////////////////
/// Test cases correctly caught by bugprone-too-small-loop-variable.
void voidBadForLoop() {
for (int i = 0; i < size(); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidBadForLoop2() {
for (int i = 0; i < size() + 10; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidBadForLoop3() {
for (int i = 0; i <= size() - 1; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidBadForLoop4() {
for (int i = 0; size() > i; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:28: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidBadForLoop5() {
for (int i = 0; size() - 1 >= i; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:33: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidBadForLoop6() {
int i = 0;
for (; i < size(); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:10: warning: loop variable has narrower type 'int' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidForLoopUnsignedBound() {
unsigned size = 3147483647;
for (int i = 0; i < size; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:19: warning: loop variable has narrower type 'int' than iteration's upper bound 'unsigned int' [bugprone-too-small-loop-variable]
}
}
// The iteration's upper bound has a template dependent value.
template <long size>
void doSomething() {
for (short i = 0; i < size; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: loop variable has narrower type 'short' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
// The iteration's upper bound has a template dependent type.
template <class T>
void doSomething() {
for (T i = 0; i < size(); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:17: warning: loop variable has narrower type 'short' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
void voidForLoopInstantiation() {
// This line does not trigger the warning.
doSomething<long>();
// This one triggers the warning.
doSomething<short>();
}
// A suspicious function used in a macro.
#define SUSPICIOUS_SIZE (size())
void voidBadForLoopWithMacroBound() {
for (short i = 0; i < SUSPICIOUS_SIZE; ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: loop variable has narrower type 'short' than iteration's upper bound 'long' [bugprone-too-small-loop-variable]
}
}
////////////////////////////////////////////////////////////////////////////////
/// Correct loops: we should not warn here.
// A simple use case when both expressions have the same type.
void voidGoodForLoop() {
for (long i = 0; i < size(); ++i) { // no warning
}
}
// Other use case where both expressions have the same type,
// but short expressions are converted to int by the compare operator.
void voidGoodForLoop2() {
short loopCond = 10;
for (short i = 0; i < loopCond; ++i) { // no warning
}
}
// Because of the integer literal, the iteration's upper bound is int, but we suppress the warning here.
void voidForLoopShortPlusLiteral() {
short size = 30000;
for (short i = 0; i <= (size - 1); ++i) { // no warning
}
}
// Addition of two short variables results in an int value, but we suppress this to avoid false positives.
void voidForLoopShortPlusShort() {
short size = 256;
short increment = 14;
for (short i = 0; i < size + increment; ++i) { // no warning
}
}
// In this test case we have different integer types, but here the loop variable has the bigger type.
// The iteration's bound is cast implicitly, not the loop variable.
void voidForLoopBoundImplicitCast() {
short start = 256;
short end = 14;
for (int i = start; i >= end; --i) { // no warning
}
}
// Range based loop and other iterator based loops are ignored by this check.
void voidRangeBasedForLoop() {
int array[] = {1, 2, 3, 4, 5};
for (const int &i : array) { // no warning
}
}
////////////////////////////////////////////////////////////////////////////////
/// Future possibilites to improve the check.
// False positive: because of the int literal, iteration's upper bound has int type.
void voidForLoopFalsePositive() {
short size = 30000;
bool cond = false;
for (short i = 0; i < (cond ? 0 : size); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: loop variable has narrower type 'short' than iteration's upper bound 'int' [bugprone-too-small-loop-variable]
}
}
void voidForLoopFalsePositive2() {
short size = 30000;
bool cond = false;
for (short i = 0; i < (!cond ? size : 0); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: loop variable has narrower type 'short' than iteration's upper bound 'int' [bugprone-too-small-loop-variable]
}
}
// False positive: The loop bound expression contains nested binary operators.
void voidForLoopFalsePositive3() {
short number = 30000;
for (short i = 0; i < ((number & 0x7f) + 1); ++i) {
// CHECK-MESSAGES: :[[@LINE-1]]:21: warning: loop variable has narrower type 'short' than iteration's upper bound 'int' [bugprone-too-small-loop-variable]
}
}
// TODO: handle while loop.
void voidBadWhileLoop() {
short i = 0;
while (i < size()) { // missing warning
++i;
}
}
// TODO: handle do-while loop.
void voidBadDoWhileLoop() {
short i = 0;
do {
++i;
} while (i < size()); // missing warning
}
// TODO: handle complex loop conditions.
void voidComplexForCond() {
bool additionalCond = true;
for (int i = 0; i < size() && additionalCond; ++i) { // missing warning
}
}
////////////////////////////////////////////////////////////////////////////////
/// Suspicious test cases ingored by this check.
// Test case with a reverse iteration.
// This is caught by -Wimplicit-int-conversion.
void voidReverseForLoop() {
for (short i = size() - 1; i >= 0; --i) { // no warning
}
}
// Macro defined literals are used inside the loop condition.
#define SIZE 125
#define SIZE2 (SIZE + 1)
void voidForLoopWithMacroBound() {
for (short i = 0; i < SIZE2; ++i) { // no warning
}
}
// A suspicious loop is not caught if the iteration's upper bound is a literal.
void voidForLoopWithLiteralBound() {
for (short i = 0; i < 125; ++i) { // no warning
}
}
// The used literal leads to an infinite loop.
// This is caught by -Wtautological-constant-out-of-range-compare.
void voidForLoopWithBigLiteralBound() {
for (short i = 0; i < 294967296l; ++i) { // no warning
}
}
enum eSizeType {
START,
Y,
END
};
// A suspicious loop is not caught if the iteration's upper bound is an enum value.
void voidForLoopWithEnumBound() {
for (short i = eSizeType::START; i < eSizeType::END; ++i) { // no warning
}
}
enum eSizeType2 : long {
START2 = 294967296l,
Y2,
END2
};
// The used enum value leads to an infinite loop.
// This is caught by -Wtautological-constant-out-of-range-compare.
void voidForLoopWithBigEnumBound() {
for (short i = eSizeType2::START2; i < eSizeType2::END2; ++i) { // no warning
}
}
// A suspicious loop is not caught if the iteration's upper bound is a constant variable.
void voidForLoopWithConstBound() {
const long size = 252l;
for (short i = 0; i < size; ++i) { // no warning
}
}
// The used constant variable leads to an infinite loop.
// This is caught by -Wtautological-constant-out-of-range-compare.
void voidForLoopWithBigConstBound() {
const long size = 294967296l;
for (short i = 0; i < size; ++i) { // no warning
}
}