QualifiedAutoCheck.cpp
10.5 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
//===--- QualifiedAutoCheck.cpp - clang-tidy ------------------------------===//
//
// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
// See https://llvm.org/LICENSE.txt for license information.
// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
//
//===----------------------------------------------------------------------===//
#include "QualifiedAutoCheck.h"
#include "../utils/LexerUtils.h"
#include "clang/ASTMatchers/ASTMatchers.h"
#include "llvm/ADT/Optional.h"
#include "llvm/ADT/SmallVector.h"
using namespace clang::ast_matchers;
namespace clang {
namespace tidy {
namespace readability {
namespace {
// FIXME move to ASTMatchers
AST_MATCHER_P(QualType, hasUnqualifiedType,
ast_matchers::internal::Matcher<QualType>, InnerMatcher) {
return InnerMatcher.matches(Node.getUnqualifiedType(), Finder, Builder);
}
enum class Qualifier { Const, Volatile, Restrict };
llvm::Optional<Token> findQualToken(const VarDecl *Decl, Qualifier Qual,
const MatchFinder::MatchResult &Result) {
// Since either of the locs can be in a macro, use `makeFileCharRange` to be
// sure that we have a consistent `CharSourceRange`, located entirely in the
// source file.
assert((Qual == Qualifier::Const || Qual == Qualifier::Volatile ||
Qual == Qualifier::Restrict) &&
"Invalid Qualifier");
SourceLocation BeginLoc = Decl->getQualifierLoc().getBeginLoc();
if (BeginLoc.isInvalid())
BeginLoc = Decl->getBeginLoc();
SourceLocation EndLoc = Decl->getLocation();
CharSourceRange FileRange = Lexer::makeFileCharRange(
CharSourceRange::getCharRange(BeginLoc, EndLoc), *Result.SourceManager,
Result.Context->getLangOpts());
if (FileRange.isInvalid())
return llvm::None;
tok::TokenKind Tok =
Qual == Qualifier::Const
? tok::kw_const
: Qual == Qualifier::Volatile ? tok::kw_volatile : tok::kw_restrict;
return utils::lexer::getQualifyingToken(Tok, FileRange, *Result.Context,
*Result.SourceManager);
}
llvm::Optional<SourceRange>
getTypeSpecifierLocation(const VarDecl *Var,
const MatchFinder::MatchResult &Result) {
SourceRange TypeSpecifier(
Var->getTypeSpecStartLoc(),
Var->getTypeSpecEndLoc().getLocWithOffset(Lexer::MeasureTokenLength(
Var->getTypeSpecEndLoc(), *Result.SourceManager,
Result.Context->getLangOpts())));
if (TypeSpecifier.getBegin().isMacroID() ||
TypeSpecifier.getEnd().isMacroID())
return llvm::None;
return TypeSpecifier;
}
llvm::Optional<SourceRange> mergeReplacementRange(SourceRange &TypeSpecifier,
const Token &ConstToken) {
if (TypeSpecifier.getBegin().getLocWithOffset(-1) == ConstToken.getEndLoc()) {
TypeSpecifier.setBegin(ConstToken.getLocation());
return llvm::None;
}
if (TypeSpecifier.getEnd().getLocWithOffset(1) == ConstToken.getLocation()) {
TypeSpecifier.setEnd(ConstToken.getEndLoc());
return llvm::None;
}
return SourceRange(ConstToken.getLocation(), ConstToken.getEndLoc());
}
bool isPointerConst(QualType QType) {
QualType Pointee = QType->getPointeeType();
assert(!Pointee.isNull() && "can't have a null Pointee");
return Pointee.isConstQualified();
}
bool isAutoPointerConst(QualType QType) {
QualType Pointee =
cast<AutoType>(QType->getPointeeType().getTypePtr())->desugar();
assert(!Pointee.isNull() && "can't have a null Pointee");
return Pointee.isConstQualified();
}
} // namespace
void QualifiedAutoCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) {
Options.store(Opts, "AddConstToQualified", AddConstToQualified);
}
void QualifiedAutoCheck::registerMatchers(MatchFinder *Finder) {
auto ExplicitSingleVarDecl =
[](const ast_matchers::internal::Matcher<VarDecl> &InnerMatcher,
llvm::StringRef ID) {
return declStmt(
unless(isInTemplateInstantiation()),
hasSingleDecl(
varDecl(unless(isImplicit()), InnerMatcher).bind(ID)));
};
auto ExplicitSingleVarDeclInTemplate =
[](const ast_matchers::internal::Matcher<VarDecl> &InnerMatcher,
llvm::StringRef ID) {
return declStmt(
isInTemplateInstantiation(),
hasSingleDecl(
varDecl(unless(isImplicit()), InnerMatcher).bind(ID)));
};
auto IsBoundToType = refersToType(equalsBoundNode("type"));
Finder->addMatcher(
ExplicitSingleVarDecl(hasType(autoType(hasDeducedType(
pointerType(pointee(unless(functionType())))))),
"auto"),
this);
Finder->addMatcher(
ExplicitSingleVarDeclInTemplate(
allOf(hasType(autoType(hasDeducedType(pointerType(
pointee(hasUnqualifiedType(qualType().bind("type")),
unless(functionType())))))),
anyOf(hasAncestor(
functionDecl(hasAnyTemplateArgument(IsBoundToType))),
hasAncestor(classTemplateSpecializationDecl(
hasAnyTemplateArgument(IsBoundToType))))),
"auto"),
this);
if (!AddConstToQualified)
return;
Finder->addMatcher(ExplicitSingleVarDecl(
hasType(pointerType(pointee(autoType()))), "auto_ptr"),
this);
Finder->addMatcher(
ExplicitSingleVarDecl(hasType(lValueReferenceType(pointee(autoType()))),
"auto_ref"),
this);
}
void QualifiedAutoCheck::check(const MatchFinder::MatchResult &Result) {
if (const auto *Var = Result.Nodes.getNodeAs<VarDecl>("auto")) {
SourceRange TypeSpecifier;
if (llvm::Optional<SourceRange> TypeSpec =
getTypeSpecifierLocation(Var, Result)) {
TypeSpecifier = *TypeSpec;
} else
return;
llvm::SmallVector<SourceRange, 4> RemoveQualifiersRange;
auto CheckQualifier = [&](bool IsPresent, Qualifier Qual) {
if (IsPresent) {
llvm::Optional<Token> Token = findQualToken(Var, Qual, Result);
if (!Token || Token->getLocation().isMacroID())
return true; // Disregard this VarDecl.
if (llvm::Optional<SourceRange> Result =
mergeReplacementRange(TypeSpecifier, *Token))
RemoveQualifiersRange.push_back(*Result);
}
return false;
};
bool IsLocalConst = Var->getType().isLocalConstQualified();
bool IsLocalVolatile = Var->getType().isLocalVolatileQualified();
bool IsLocalRestrict = Var->getType().isLocalRestrictQualified();
if (CheckQualifier(IsLocalConst, Qualifier::Const) ||
CheckQualifier(IsLocalVolatile, Qualifier::Volatile) ||
CheckQualifier(IsLocalRestrict, Qualifier::Restrict))
return;
// Check for bridging the gap between the asterisk and name.
if (Var->getLocation() == TypeSpecifier.getEnd().getLocWithOffset(1))
TypeSpecifier.setEnd(TypeSpecifier.getEnd().getLocWithOffset(1));
CharSourceRange FixItRange = CharSourceRange::getCharRange(TypeSpecifier);
if (FixItRange.isInvalid())
return;
SourceLocation FixitLoc = FixItRange.getBegin();
for (SourceRange &Range : RemoveQualifiersRange) {
if (Range.getBegin() < FixitLoc)
FixitLoc = Range.getBegin();
}
std::string ReplStr = [&] {
llvm::StringRef PtrConst = isPointerConst(Var->getType()) ? "const " : "";
llvm::StringRef LocalConst = IsLocalConst ? "const " : "";
llvm::StringRef LocalVol = IsLocalVolatile ? "volatile " : "";
llvm::StringRef LocalRestrict = IsLocalRestrict ? "__restrict " : "";
return (PtrConst + "auto *" + LocalConst + LocalVol + LocalRestrict)
.str();
}();
DiagnosticBuilder Diag =
diag(FixitLoc, "'%0%1%2auto %3' can be declared as '%4%3'")
<< (IsLocalConst ? "const " : "")
<< (IsLocalVolatile ? "volatile " : "")
<< (IsLocalRestrict ? "__restrict " : "") << Var->getName() << ReplStr;
for (SourceRange &Range : RemoveQualifiersRange) {
Diag << FixItHint::CreateRemoval(CharSourceRange::getCharRange(Range));
}
Diag << FixItHint::CreateReplacement(FixItRange, ReplStr);
return;
}
if (const auto *Var = Result.Nodes.getNodeAs<VarDecl>("auto_ptr")) {
if (!isPointerConst(Var->getType()))
return; // Pointer isn't const, no need to add const qualifier.
if (!isAutoPointerConst(Var->getType()))
return; // Const isnt wrapped in the auto type, so must be declared
// explicitly.
if (Var->getType().isLocalConstQualified()) {
llvm::Optional<Token> Token =
findQualToken(Var, Qualifier::Const, Result);
if (!Token || Token->getLocation().isMacroID())
return;
}
if (Var->getType().isLocalVolatileQualified()) {
llvm::Optional<Token> Token =
findQualToken(Var, Qualifier::Volatile, Result);
if (!Token || Token->getLocation().isMacroID())
return;
}
if (Var->getType().isLocalRestrictQualified()) {
llvm::Optional<Token> Token =
findQualToken(Var, Qualifier::Restrict, Result);
if (!Token || Token->getLocation().isMacroID())
return;
}
if (llvm::Optional<SourceRange> TypeSpec =
getTypeSpecifierLocation(Var, Result)) {
if (TypeSpec->isInvalid() || TypeSpec->getBegin().isMacroID() ||
TypeSpec->getEnd().isMacroID())
return;
SourceLocation InsertPos = TypeSpec->getBegin();
diag(InsertPos, "'auto *%0%1%2' can be declared as 'const auto *%0%1%2'")
<< (Var->getType().isLocalConstQualified() ? "const " : "")
<< (Var->getType().isLocalVolatileQualified() ? "volatile " : "")
<< Var->getName() << FixItHint::CreateInsertion(InsertPos, "const ");
}
return;
}
if (const auto *Var = Result.Nodes.getNodeAs<VarDecl>("auto_ref")) {
if (!isPointerConst(Var->getType()))
return; // Pointer isn't const, no need to add const qualifier.
if (!isAutoPointerConst(Var->getType()))
// Const isnt wrapped in the auto type, so must be declared explicitly.
return;
if (llvm::Optional<SourceRange> TypeSpec =
getTypeSpecifierLocation(Var, Result)) {
if (TypeSpec->isInvalid() || TypeSpec->getBegin().isMacroID() ||
TypeSpec->getEnd().isMacroID())
return;
SourceLocation InsertPos = TypeSpec->getBegin();
diag(InsertPos, "'auto &%0' can be declared as 'const auto &%0'")
<< Var->getName() << FixItHint::CreateInsertion(InsertPos, "const ");
}
return;
}
}
} // namespace readability
} // namespace tidy
} // namespace clang