bugprone-misplaced-widening-cast-explicit-only.cpp
2.05 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
// RUN: %check_clang_tidy %s bugprone-misplaced-widening-cast %t -- -config="{CheckOptions: [{key: bugprone-misplaced-widening-cast.CheckImplicitCasts, value: 0}]}" --
void func(long arg) {}
void assign(int a, int b) {
long l;
l = a * b;
l = (long)(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long' is ineffective, or there is loss of precision before the conversion [bugprone-misplaced-widening-cast]
l = (long)a * b;
l = a << 8;
l = (long)(a << 8);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = (long)b << 8;
l = static_cast<long>(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
}
void compare(int a, int b, long c) {
bool l;
l = a * b == c;
l = c == a * b;
l = (long)(a * b) == c;
// CHECK-MESSAGES: :[[@LINE-1]]:7: warning: either cast from 'int' to 'long'
l = c == (long)(a * b);
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
l = (long)a * b == c;
l = c == (long)a * b;
}
void init(unsigned int n) {
long l1 = n << 8;
long l2 = (long)(n << 8);
// CHECK-MESSAGES: :[[@LINE-1]]:13: warning: either cast from 'unsigned int' to 'long'
long l3 = (long)n << 8;
}
void call(unsigned int n) {
func(n << 8);
func((long)(n << 8));
// CHECK-MESSAGES: :[[@LINE-1]]:8: warning: either cast from 'unsigned int' to 'long'
func((long)n << 8);
}
long ret(int a) {
if (a < 0) {
return a * 1000;
} else if (a > 0) {
return (long)(a * 1000);
// CHECK-MESSAGES: :[[@LINE-1]]:12: warning: either cast from 'int' to 'long'
} else {
return (long)a * 1000;
}
}
// Shall not generate an assert. https://bugs.llvm.org/show_bug.cgi?id=33660
template <class> class A {
enum Type {};
static char *m_fn1() { char p = (Type)(&p - m_fn1()); }
};
enum DaysEnum {
MON,
TUE,
WED,
THR,
FRI,
SAT,
SUN
};
// Do not warn for int to enum casts.
void nextDay(DaysEnum day) {
if (day < SUN)
day = (DaysEnum)(day + 1);
if (day < SUN)
day = static_cast<DaysEnum>(day + 1);
}