Fixing drivers & providers Buck app builds

Change-Id: I6a02a68568037eca0a0b82ad4f83ff18bfeada5f

@@ -12,6 +12,11 @@ TEST_DEPS = [
     '//core/api:onos-api-tests',
 ]
 
+BUNDLES = [
+    ':onos-drivers-arista',
+    '//drivers/utilities:onos-drivers-utilities',
+]
+
 osgi_jar_with_tests (
     deps = COMPILE_DEPS,
     test_deps = TEST_DEPS,
@@ -20,9 +25,11 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.arista',
     title = 'Arista Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS Arista Device Drivers application.',
+    included_bundles = BUNDLES,
     required_apps = [ 'org.onosproject.restsb' ],
-)
\ No newline at end of file
+)

@@ -21,6 +21,7 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.bti',
     title = 'Bti Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',

@@ -11,6 +11,11 @@ TEST_DEPS = [
     '//core/api:onos-api-tests',
 ]
 
+BUNDLES = [
+    ':onos-drivers-ciena',
+    '//drivers/utilities:onos-drivers-utilities',
+]
+
 osgi_jar_with_tests (
     deps = COMPILE_DEPS,
     test_deps = TEST_DEPS,
@@ -19,9 +24,11 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.ciena',
     title = 'Ciena Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS Ciena Device Drivers application.',
+    included_bundles = BUNDLES,
     required_apps = [ 'org.onosproject.restsb' ],
 )

@@ -9,6 +9,11 @@ TEST_DEPS = [
     '//core/api:onos-api-tests',
 ]
 
+BUNDLES = [
+    ':onos-drivers-cisco',
+    '//drivers/utilities:onos-drivers-utilities',
+]
+
 osgi_jar_with_tests (
     deps = COMPILE_DEPS,
     test_deps = TEST_DEPS,
@@ -17,9 +22,11 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.cisco',
     title = 'Cisco device drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS Cisco device drivers application.',
-    required_apps = [ 'org.onosproject.netconf' ],
+    included_bundles = BUNDLES,
+    required_apps = [ 'org.onosproject.netconf', 'org.onosproject.drivers.netconf' ],
 )

@@ -11,6 +11,11 @@ TEST_DEPS = [
     '//core/api:onos-api-tests',
 ]
 
+BUNDLES = [
+    ':onos-drivers-fujitsu',
+    '//drivers/utilities:onos-drivers-utilities',
+]
+
 osgi_jar_with_tests (
     deps = COMPILE_DEPS,
     test_deps = TEST_DEPS,
@@ -19,9 +24,11 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.fujitsu',
     title = 'Fujitsu device drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS Fujitsu device drivers application.',
+    included_bundles = BUNDLES,
     required_apps = [ 'org.onosproject.netconf' ],
 )

@@ -17,6 +17,7 @@
 package org.onosproject.drivers.fujitsu;
 
 import org.apache.felix.scr.annotations.Component;
+import org.onosproject.cli.net.DeviceIdCompleter;
 import org.onosproject.net.driver.AbstractDriverLoader;
 import org.onosproject.net.optical.OpticalDevice;
 
@@ -29,6 +30,8 @@ public class FujitsuDriversLoader extends AbstractDriverLoader {
     // OSGI: help bundle plugin discover runtime package dependency.
     @SuppressWarnings("unused")
     private OpticalDevice optical;
+    @SuppressWarnings("unused")
+    private DeviceIdCompleter deviceIdCompleter;
 
     public FujitsuDriversLoader() {
         super("/fujitsu-drivers.xml");

@@ -19,6 +19,7 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.lumentum',
     title = 'Lumentum Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',

@@ -9,6 +9,11 @@ TEST_DEPS = [
     '//core/api:onos-api-tests',
 ]
 
+BUNDLES = [
+    ':onos-drivers-netconf',
+    '//drivers/utilities:onos-drivers-utilities',
+]
+
 osgi_jar_with_tests (
     deps = COMPILE_DEPS,
     test_deps = TEST_DEPS,
@@ -17,8 +22,11 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.netconf',
     title = 'NETCONF Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS NETCONF Device Drivers application.',
+    included_bundles = BUNDLES,
+    required_apps = [ 'org.onosproject.netconf' ],
 )

@@ -18,6 +18,7 @@ osgi_jar_with_tests (
 )
 
 onos_app (
+    app_name = 'org.onosproject.drivers.optical',
     title = 'Other optical Device Drivers',
     category = 'Drivers',
     url = 'http://onosproject.org',

@@ -23,4 +23,5 @@ onos_app (
     category = 'Drivers',
     url = 'http://onosproject.org',
     description = 'ONOS OVSDB Device Drivers application.',
+    required_apps = [ 'org.onosproject.ovsdb' ],
 )

@@ -46,16 +46,6 @@ CORE = [
     '//protocols/isis/isisio:onos-protocols-isis-isisio',
 
     '//drivers/utilities:onos-drivers-utilities',
-    '//drivers/bti:onos-drivers-bti-oar',
-    '//drivers/ciena:onos-drivers-ciena-oar',
-    '//drivers/cisco:onos-drivers-cisco-oar',
-    '//drivers/default:onos-drivers-default-oar',
-    '//drivers/fujitsu:onos-drivers-fujitsu-oar',
-    '//drivers/lumentum:onos-drivers-lumentum-oar',
-    '//drivers/netconf:onos-drivers-netconf-oar',
-    '//drivers/ovsdb:onos-drivers-ovsdb-oar',
-    '//drivers/optical:onos-drivers-optical-oar',
-    '//drivers/arista:onos-drivers-arista-oar',
 
     '//providers/netconf/device:onos-providers-netconf-device',
     '//providers/openflow/device:onos-providers-openflow-device',
@@ -77,7 +67,15 @@ CORE = [
 ONOS_DRIVERS = [
     # Drivers
     '//drivers/default:onos-drivers-default-oar',
+    '//drivers/arista:onos-drivers-arista-oar',
+    '//drivers/bti:onos-drivers-bti-oar',
+    '//drivers/ciena:onos-drivers-ciena-oar',
+    '//drivers/cisco:onos-drivers-cisco-oar',
     '//drivers/corsa:onos-drivers-corsa-oar',
+    '//drivers/fujitsu:onos-drivers-fujitsu-oar',
+    '//drivers/lumentum:onos-drivers-lumentum-oar',
+    '//drivers/netconf:onos-drivers-netconf-oar',
+    '//drivers/optical:onos-drivers-optical-oar',
     '//drivers/ovsdb:onos-drivers-ovsdb-oar',
 ]
 

@@ -9,7 +9,8 @@ BUNDLES = [
 ]
 
 onos_app (
-    title = 'PCEP Provider',
+    app_name = 'org.onosproject.restsb',
+    title = 'REST Provider',
     category = 'Provider',
     url = 'http://onosproject.org',
     included_bundles = BUNDLES,

@@ -2,9 +2,14 @@ BUNDLES = [
   '//providers/snmp/device:onos-providers-snmp-device',
   '//protocols/snmp/api:onos-protocols-snmp-api',
   '//protocols/snmp/ctl:onos-protocols-snmp-ctl',
+  '//lib:org.apache.servicemix.bundles.snmp4j',
+  '//lib:snmp-core',
+  '//lib:bti7000',
+  '//lib:mibs-net-snmp',
 ]
 
 onos_app (
+    app_name = 'org.onosproject.snmp',
     title = 'SNMP Provider',
     category = 'Provider',
     url = 'http://onosproject.org',