Added Host related memos.
Change-Id: Idbbce6a72b6f7fecc6691f2af68f4ce40b58ca34
Showing
7 changed files
with
8 additions
and
0 deletions
... | @@ -20,6 +20,7 @@ public class DefaultHost extends AbstractElement implements Host { | ... | @@ -20,6 +20,7 @@ public class DefaultHost extends AbstractElement implements Host { |
20 | private final MacAddress mac; | 20 | private final MacAddress mac; |
21 | private final VlanId vlan; | 21 | private final VlanId vlan; |
22 | private final HostLocation location; | 22 | private final HostLocation location; |
23 | + // FIXME: should be IpAddress | ||
23 | private final Set<IpPrefix> ips; | 24 | private final Set<IpPrefix> ips; |
24 | 25 | ||
25 | /** | 26 | /** | ... | ... |
... | @@ -38,6 +38,7 @@ public interface Host extends Element { | ... | @@ -38,6 +38,7 @@ public interface Host extends Element { |
38 | * | 38 | * |
39 | * @return set of IP addresses; empty if no IP address is bound | 39 | * @return set of IP addresses; empty if no IP address is bound |
40 | */ | 40 | */ |
41 | + // FIXME: Switch to IpAddress | ||
41 | Set<IpPrefix> ipAddresses(); | 42 | Set<IpPrefix> ipAddresses(); |
42 | 43 | ||
43 | /** | 44 | /** | ... | ... |
... | @@ -37,6 +37,7 @@ public interface HostDescription extends Description { | ... | @@ -37,6 +37,7 @@ public interface HostDescription extends Description { |
37 | * | 37 | * |
38 | * @return host IP address | 38 | * @return host IP address |
39 | */ | 39 | */ |
40 | + // FIXME: Switch to IpAddress | ||
40 | IpPrefix ipAddress(); | 41 | IpPrefix ipAddress(); |
41 | 42 | ||
42 | } | 43 | } | ... | ... |
... | @@ -29,6 +29,7 @@ public interface HostStore extends Store<HostEvent, HostStoreDelegate> { | ... | @@ -29,6 +29,7 @@ public interface HostStore extends Store<HostEvent, HostStoreDelegate> { |
29 | HostEvent createOrUpdateHost(ProviderId providerId, HostId hostId, | 29 | HostEvent createOrUpdateHost(ProviderId providerId, HostId hostId, |
30 | HostDescription hostDescription); | 30 | HostDescription hostDescription); |
31 | 31 | ||
32 | + // FIXME: API to remove only IpAddress is missing | ||
32 | /** | 33 | /** |
33 | * Removes the specified host from the inventory. | 34 | * Removes the specified host from the inventory. |
34 | * | 35 | * |
... | @@ -81,6 +82,7 @@ public interface HostStore extends Store<HostEvent, HostStoreDelegate> { | ... | @@ -81,6 +82,7 @@ public interface HostStore extends Store<HostEvent, HostStoreDelegate> { |
81 | * @param ip ip address | 82 | * @param ip ip address |
82 | * @return set of hosts with the given IP | 83 | * @return set of hosts with the given IP |
83 | */ | 84 | */ |
85 | + // FIXME: Switch to IpAddress | ||
84 | Set<Host> getHosts(IpPrefix ip); | 86 | Set<Host> getHosts(IpPrefix ip); |
85 | 87 | ||
86 | /** | 88 | /** | ... | ... |
... | @@ -17,6 +17,7 @@ import com.google.common.base.MoreObjects; | ... | @@ -17,6 +17,7 @@ import com.google.common.base.MoreObjects; |
17 | public class PortAddresses { | 17 | public class PortAddresses { |
18 | 18 | ||
19 | private final ConnectPoint connectPoint; | 19 | private final ConnectPoint connectPoint; |
20 | + // TODO: Should this be IpAddress or IpPrefix? | ||
20 | private final Set<IpPrefix> ipAddresses; | 21 | private final Set<IpPrefix> ipAddresses; |
21 | private final MacAddress macAddress; | 22 | private final MacAddress macAddress; |
22 | 23 | ... | ... |
... | @@ -43,6 +43,7 @@ import java.util.concurrent.ConcurrentHashMap; | ... | @@ -43,6 +43,7 @@ import java.util.concurrent.ConcurrentHashMap; |
43 | import static org.onlab.onos.net.host.HostEvent.Type.*; | 43 | import static org.onlab.onos.net.host.HostEvent.Type.*; |
44 | import static org.slf4j.LoggerFactory.getLogger; | 44 | import static org.slf4j.LoggerFactory.getLogger; |
45 | 45 | ||
46 | +//TODO: multi-provider, annotation not supported. | ||
46 | /** | 47 | /** |
47 | * Manages inventory of end-station hosts in distributed data store | 48 | * Manages inventory of end-station hosts in distributed data store |
48 | * that uses optimistic replication and gossip based techniques. | 49 | * that uses optimistic replication and gossip based techniques. | ... | ... |
... | @@ -35,6 +35,7 @@ import java.util.concurrent.ConcurrentHashMap; | ... | @@ -35,6 +35,7 @@ import java.util.concurrent.ConcurrentHashMap; |
35 | import static org.onlab.onos.net.host.HostEvent.Type.*; | 35 | import static org.onlab.onos.net.host.HostEvent.Type.*; |
36 | import static org.slf4j.LoggerFactory.getLogger; | 36 | import static org.slf4j.LoggerFactory.getLogger; |
37 | 37 | ||
38 | +// TODO: multi-provider, annotation not supported. | ||
38 | /** | 39 | /** |
39 | * Manages inventory of end-station hosts using trivial in-memory | 40 | * Manages inventory of end-station hosts using trivial in-memory |
40 | * implementation. | 41 | * implementation. | ... | ... |
-
Please register or login to post a comment