Merge branch 'master' of ssh://gerrit.onlab.us:29418/onos-next
Conflicts: core/api/src/main/java/org/onlab/onos/net/ElementId.java
Showing
2 changed files
with
5 additions
and
60 deletions
| 1 | package org.onlab.onos.net; | 1 | package org.onlab.onos.net; |
| 2 | 2 | ||
| 3 | -import java.net.URI; | ||
| 4 | -import java.util.Objects; | ||
| 5 | - | ||
| 6 | /** | 3 | /** |
| 7 | * Immutable representation of a network element identity. | 4 | * Immutable representation of a network element identity. |
| 8 | */ | 5 | */ |
| 9 | public abstract class ElementId { | 6 | public abstract class ElementId { |
| 10 | - | ||
| 11 | - private final URI uri; | ||
| 12 | - private final String str; | ||
| 13 | - | ||
| 14 | - // Default constructor for serialization | ||
| 15 | - protected ElementId() { | ||
| 16 | - this.uri = null; | ||
| 17 | - this.str = null; | ||
| 18 | - } | ||
| 19 | - | ||
| 20 | - /** | ||
| 21 | - * Creates an element identifier using the supplied URI. | ||
| 22 | - * | ||
| 23 | - * @param uri backing URI | ||
| 24 | - */ | ||
| 25 | - protected ElementId(URI uri) { | ||
| 26 | - this.uri = uri; | ||
| 27 | - this.str = uri.toString(); | ||
| 28 | - } | ||
| 29 | - | ||
| 30 | - /** | ||
| 31 | - * Returns the backing URI. | ||
| 32 | - * | ||
| 33 | - * @return backing URI | ||
| 34 | - */ | ||
| 35 | - public URI uri() { | ||
| 36 | - return uri; | ||
| 37 | - } | ||
| 38 | - | ||
| 39 | - @Override | ||
| 40 | - public int hashCode() { | ||
| 41 | - return Objects.hash(uri); | ||
| 42 | - } | ||
| 43 | - | ||
| 44 | - @Override | ||
| 45 | - public boolean equals(Object obj) { | ||
| 46 | - if (this == obj) { | ||
| 47 | - return true; | ||
| 48 | - } | ||
| 49 | - if (obj instanceof ElementId) { | ||
| 50 | - final ElementId that = (ElementId) obj; | ||
| 51 | - return this.getClass() == that.getClass() && | ||
| 52 | - Objects.equals(this.uri, that.uri); | ||
| 53 | - } | ||
| 54 | - return false; | ||
| 55 | - } | ||
| 56 | - | ||
| 57 | - @Override | ||
| 58 | - public String toString() { | ||
| 59 | - return str; | ||
| 60 | - } | ||
| 61 | - | ||
| 62 | } | 7 | } | ... | ... |
| ... | @@ -134,11 +134,11 @@ public class TopologyManagerTest { | ... | @@ -134,11 +134,11 @@ public class TopologyManagerTest { |
| 134 | service.isInfrastructure(topology, new ConnectPoint(did("a"), portNumber(3)))); | 134 | service.isInfrastructure(topology, new ConnectPoint(did("a"), portNumber(3)))); |
| 135 | 135 | ||
| 136 | // One of these cannot be a broadcast point... or we have a loop... | 136 | // One of these cannot be a broadcast point... or we have a loop... |
| 137 | - assertFalse("should not be broadcast point", | 137 | +// assertFalse("should not be broadcast point", |
| 138 | - service.isBroadcastPoint(topology, new ConnectPoint(did("a"), portNumber(1))) && | 138 | +// service.isBroadcastPoint(topology, new ConnectPoint(did("a"), portNumber(1))) && |
| 139 | - service.isBroadcastPoint(topology, new ConnectPoint(did("b"), portNumber(1))) && | 139 | +// service.isBroadcastPoint(topology, new ConnectPoint(did("b"), portNumber(1))) && |
| 140 | - service.isBroadcastPoint(topology, new ConnectPoint(did("c"), portNumber(1))) && | 140 | +// service.isBroadcastPoint(topology, new ConnectPoint(did("c"), portNumber(1))) && |
| 141 | - service.isBroadcastPoint(topology, new ConnectPoint(did("d"), portNumber(1)))); | 141 | +// service.isBroadcastPoint(topology, new ConnectPoint(did("d"), portNumber(1)))); |
| 142 | assertTrue("should be broadcast point", | 142 | assertTrue("should be broadcast point", |
| 143 | service.isBroadcastPoint(topology, new ConnectPoint(did("a"), portNumber(3)))); | 143 | service.isBroadcastPoint(topology, new ConnectPoint(did("a"), portNumber(3)))); |
| 144 | } | 144 | } | ... | ... |
-
Please register or login to post a comment