홍길동 / onos

Go to a project
Toggle navigation Toggle navigation pinning
Michael Jarschel
Committed by Gerrit Code Review
7f521a34 1 parent 6a8d5528

Fix to avoid unnecessary configuration message when switch does not have buffer 

Change-Id: I688964ebd1f1218b51736b9918f3cc9184552fe5
Inline Side-by-side
Showing 1 changed file with 10 additions and 6 deletions
...@@ -1263,12 +1263,16 @@ class OFChannelHandler extends IdleStateAwareChannelHandler { ...@@ -1263,12 +1263,16 @@ class OFChannelHandler extends IdleStateAwareChannelHandler {
1263 1263
1264 // Ensure we receive the full packet via PacketIn 1264 // Ensure we receive the full packet via PacketIn
1265 // FIXME: We don't set the reassembly flags. 1265 // FIXME: We don't set the reassembly flags.
1266 - OFSetConfig sc = factory 1266 + // Only send config to switches to send full packets, if they have a buffer.
1267 - .buildSetConfig() 1267 + // Saves a packet & OFSetConfig can't be handled by certain switches.
1268 - .setMissSendLen((short) 0xffff) 1268 + if(this.featuresReply.getNBuffers() > 0) {
1269 - .setXid(this.handshakeTransactionIds--) 1269 + OFSetConfig sc = factory
1270 - .build(); 1270 + .buildSetConfig()
1271 - msglist.add(sc); 1271 + .setMissSendLen((short) 0xffff)
1272 + .setXid(this.handshakeTransactionIds--)
1273 + .build();
1274 + msglist.add(sc);
1275 + }
1272 1276
1273 // Barrier 1277 // Barrier
1274 OFBarrierRequest br = factory 1278 OFBarrierRequest br = factory
......