alshabib

fixing flow rule service timeout and notion of identity

Change-Id: I10d0fb8a797c642ef8af65b605f86559e3206976
...@@ -115,7 +115,7 @@ public class DefaultFlowRule implements FlowRule { ...@@ -115,7 +115,7 @@ public class DefaultFlowRule implements FlowRule {
115 } 115 }
116 116
117 public int hash() { 117 public int hash() {
118 - return Objects.hash(deviceId, selector, id); 118 + return Objects.hash(deviceId, selector, treatment);
119 } 119 }
120 120
121 @Override 121 @Override
...@@ -132,7 +132,7 @@ public class DefaultFlowRule implements FlowRule { ...@@ -132,7 +132,7 @@ public class DefaultFlowRule implements FlowRule {
132 if (obj instanceof DefaultFlowRule) { 132 if (obj instanceof DefaultFlowRule) {
133 DefaultFlowRule that = (DefaultFlowRule) obj; 133 DefaultFlowRule that = (DefaultFlowRule) obj;
134 return Objects.equals(deviceId, that.deviceId) && 134 return Objects.equals(deviceId, that.deviceId) &&
135 - //Objects.equals(id, that.id) && 135 + Objects.equals(id, that.id) &&
136 Objects.equals(priority, that.priority) && 136 Objects.equals(priority, that.priority) &&
137 Objects.equals(selector, that.selector); 137 Objects.equals(selector, that.selector);
138 138
...@@ -154,7 +154,7 @@ public class DefaultFlowRule implements FlowRule { ...@@ -154,7 +154,7 @@ public class DefaultFlowRule implements FlowRule {
154 154
155 @Override 155 @Override
156 public int timeout() { 156 public int timeout() {
157 - return timeout > MAX_TIMEOUT ? MAX_TIMEOUT : this.timeout; 157 + return timeout;
158 } 158 }
159 159
160 } 160 }
......
...@@ -66,6 +66,8 @@ public interface FlowRuleService { ...@@ -66,6 +66,8 @@ public interface FlowRuleService {
66 */ 66 */
67 Iterable<FlowRule> getFlowRulesById(ApplicationId id); 67 Iterable<FlowRule> getFlowRulesById(ApplicationId id);
68 68
69 + //Future<CompletedBatchOperation> applyBatch(BatchOperation<FlowRuleBatchEntry>)
70 +
69 /** 71 /**
70 * Adds the specified flow rule listener. 72 * Adds the specified flow rule listener.
71 * 73 *
......