LinkDiscovery: only reschedule if not requested to stop

Change-Id: If2ac04fbc81afec95137fbdbe22afa0c7f826e4a

@@ -82,7 +82,7 @@ public class LinkDiscovery implements TimerTask {
     private final PacketService pktService;
     private final PacketService pktService;
     private final MastershipService mastershipService;
     private final MastershipService mastershipService;
     private Timeout timeout;
     private Timeout timeout;
-    private boolean isStopped;
+    private volatile boolean isStopped;
 
 
     /**
     /**
      * Instantiates discovery manager for the given physical switch. Creates a
      * Instantiates discovery manager for the given physical switch. Creates a
@@ -243,8 +243,10 @@ public class LinkDiscovery implements TimerTask {
     public void run(final Timeout t) {
     public void run(final Timeout t) {
         boolean isMaster = mastershipService.getLocalRole(device.id()) == MASTER;
         boolean isMaster = mastershipService.getLocalRole(device.id()) == MASTER;
         if (!isMaster) {
         if (!isMaster) {
-            // reschedule timer
-            timeout = Timer.getTimer().newTimeout(this, this.probeRate, MILLISECONDS);
+            if (!isStopped()) {
+                // reschedule timer
+                timeout = Timer.getTimer().newTimeout(this, this.probeRate, MILLISECONDS);
+            }
             return;
             return;
         }
         }
 
 
@@ -280,16 +282,18 @@ public class LinkDiscovery implements TimerTask {
             }
             }
         }
         }
 
 
-        // reschedule timer
-        timeout = Timer.getTimer().newTimeout(this, this.probeRate, MILLISECONDS);
+        if (!isStopped()) {
+            // reschedule timer
+            timeout = Timer.getTimer().newTimeout(this, this.probeRate, MILLISECONDS);
+        }
     }
     }
 
 
-    public void stop() {
+    public synchronized void stop() {
         timeout.cancel();
         timeout.cancel();
         isStopped = true;
         isStopped = true;
     }
     }
 
 
-    public void start() {
+    public synchronized void start() {
         if (isStopped) {
         if (isStopped) {
             timeout = Timer.getTimer().newTimeout(this, 0, MILLISECONDS);
             timeout = Timer.getTimer().newTimeout(this, 0, MILLISECONDS);
             isStopped = false;
             isStopped = false;