Builds for
1 pipeline
passed
in
7 minutes 59 seconds
Merge branch 'bugfix/login-missing-uuid' into develop
Showing
2 changed files
with
8 additions
and
4 deletions
... | @@ -77,14 +77,17 @@ export class Connection { | ... | @@ -77,14 +77,17 @@ export class Connection { |
77 | private handleLogin( | 77 | private handleLogin( |
78 | message: ServerInboundMessage<"login"> | 78 | message: ServerInboundMessage<"login"> |
79 | ): ServerResponse<"login"> { | 79 | ): ServerResponse<"login"> { |
80 | - if (message.nickname.length > 12 || message.nickname.trim().length === 0) { | 80 | + if (message.nickname.length > 12) { |
81 | - return { ok: false }; | 81 | + return { ok: false, reason: "닉네임은 최대 12글자입니다." }; |
82 | + } | ||
83 | + if (message.nickname.trim().length === 0) { | ||
84 | + return { ok: false, reason: "닉네임을 공백으로 설정할 수 없습니다." }; | ||
82 | } | 85 | } |
83 | 86 | ||
84 | this.user = new User(message.nickname, this); | 87 | this.user = new User(message.nickname, this); |
85 | // console.log(`User ${message.username} has logged in!`); | 88 | // console.log(`User ${message.username} has logged in!`); |
86 | 89 | ||
87 | - return { ok: true }; | 90 | + return { ok: true, result: this.user.username }; |
88 | } | 91 | } |
89 | 92 | ||
90 | public handleDisconnect(): void { | 93 | public handleDisconnect(): void { | ... | ... |
... | @@ -6,7 +6,8 @@ describe("로그인", () => { | ... | @@ -6,7 +6,8 @@ describe("로그인", () => { |
6 | it("닉네임으로 로그인합니다", () => { | 6 | it("닉네임으로 로그인합니다", () => { |
7 | const roomManager = new RoomManager(); | 7 | const roomManager = new RoomManager(); |
8 | const socket = new SocketTester(roomManager); | 8 | const socket = new SocketTester(roomManager); |
9 | - socket.testOk("login", { nickname: "guest" }); | 9 | + const response = socket.test("login", { nickname: "guest" }); |
10 | + expect(response.result !== undefined).eq(true); | ||
10 | expect(socket.connection.user?.nickname).eq("guest"); | 11 | expect(socket.connection.user?.nickname).eq("guest"); |
11 | }); | 12 | }); |
12 | it("빈 닉네임으로 로그인할 수 없습니다", () => { | 13 | it("빈 닉네임으로 로그인할 수 없습니다", () => { | ... | ... |
-
Please register or login to post a comment