no-unnecessary-type-constraint.js
3.76 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
"use strict";
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
}) : (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
o[k2] = m[k];
}));
var __setModuleDefault = (this && this.__setModuleDefault) || (Object.create ? (function(o, v) {
Object.defineProperty(o, "default", { enumerable: true, value: v });
}) : function(o, v) {
o["default"] = v;
});
var __importStar = (this && this.__importStar) || function (mod) {
if (mod && mod.__esModule) return mod;
var result = {};
if (mod != null) for (var k in mod) if (k !== "default" && Object.prototype.hasOwnProperty.call(mod, k)) __createBinding(result, mod, k);
__setModuleDefault(result, mod);
return result;
};
Object.defineProperty(exports, "__esModule", { value: true });
const experimental_utils_1 = require("@typescript-eslint/experimental-utils");
const semver = __importStar(require("semver"));
const ts = __importStar(require("typescript"));
const util = __importStar(require("../util"));
const is3dot5 = semver.satisfies(ts.version, `>= 3.5.0 || >= 3.5.1-rc || >= 3.5.0-beta`, {
includePrerelease: true,
});
const is3dot9 = is3dot5 &&
semver.satisfies(ts.version, `>= 3.9.0 || >= 3.9.1-rc || >= 3.9.0-beta`, {
includePrerelease: true,
});
exports.default = util.createRule({
name: 'no-unnecessary-type-constraint',
meta: {
docs: {
category: 'Best Practices',
description: 'Disallows unnecessary constraints on generic types',
recommended: false,
suggestion: true,
},
fixable: 'code',
messages: {
unnecessaryConstraint: 'Constraining the generic type `{{name}}` to `{{constraint}}` does nothing and is unnecessary.',
},
schema: [],
type: 'suggestion',
},
defaultOptions: [],
create(context) {
if (!is3dot5) {
return {};
}
// In theory, we could use the type checker for more advanced constraint types...
// ...but in practice, these types are rare, and likely not worth requiring type info.
// https://github.com/typescript-eslint/typescript-eslint/pull/2516#discussion_r495731858
const unnecessaryConstraints = is3dot9
? new Map([
[experimental_utils_1.AST_NODE_TYPES.TSAnyKeyword, 'any'],
[experimental_utils_1.AST_NODE_TYPES.TSUnknownKeyword, 'unknown'],
])
: new Map([[experimental_utils_1.AST_NODE_TYPES.TSUnknownKeyword, 'unknown']]);
const inJsx = context.getFilename().toLowerCase().endsWith('tsx');
const checkNode = (node, inArrowFunction) => {
const constraint = unnecessaryConstraints.get(node.constraint.type);
if (constraint) {
context.report({
data: {
constraint,
name: node.name.name,
},
fix(fixer) {
return fixer.replaceTextRange([node.name.range[1], node.constraint.range[1]], inArrowFunction && inJsx ? ',' : '');
},
messageId: 'unnecessaryConstraint',
node,
});
}
};
return {
':not(ArrowFunctionExpression) > TSTypeParameterDeclaration > TSTypeParameter[constraint]'(node) {
checkNode(node, false);
},
'ArrowFunctionExpression > TSTypeParameterDeclaration > TSTypeParameter[constraint]'(node) {
checkNode(node, true);
},
};
},
});
//# sourceMappingURL=no-unnecessary-type-constraint.js.map