Minor intent cleanup
Change-Id: I72dae58879f5b45566d5f120f6fd85807460bb78
Showing
1 changed file
with
4 additions
and
3 deletions
... | @@ -181,7 +181,8 @@ public class IntentCleanup implements Runnable, IntentListener { | ... | @@ -181,7 +181,8 @@ public class IntentCleanup implements Runnable, IntentListener { |
181 | service.withdraw(intentData.intent()); | 181 | service.withdraw(intentData.intent()); |
182 | break; | 182 | break; |
183 | default: | 183 | default: |
184 | - //TODO this is an error, might want to log it | 184 | + log.warn("Trying to resubmit corrupt intent {} in state {} with request {}", |
185 | + intentData.key(), intentData.state(), intentData.request()); | ||
185 | break; | 186 | break; |
186 | } | 187 | } |
187 | } | 188 | } |
... | @@ -195,7 +196,8 @@ public class IntentCleanup implements Runnable, IntentListener { | ... | @@ -195,7 +196,8 @@ public class IntentCleanup implements Runnable, IntentListener { |
195 | service.withdraw(intentData.intent()); | 196 | service.withdraw(intentData.intent()); |
196 | break; | 197 | break; |
197 | default: | 198 | default: |
198 | - //TODO this is an error (or could be purge), might want to log it | 199 | + log.warn("Trying to resubmit pending intent {} in state {} with request {}", |
200 | + intentData.key(), intentData.state(), intentData.request()); | ||
199 | break; | 201 | break; |
200 | } | 202 | } |
201 | } | 203 | } |
... | @@ -225,7 +227,6 @@ public class IntentCleanup implements Runnable, IntentListener { | ... | @@ -225,7 +227,6 @@ public class IntentCleanup implements Runnable, IntentListener { |
225 | } | 227 | } |
226 | 228 | ||
227 | for (IntentData intentData : store.getPendingData(true, periodMs)) { | 229 | for (IntentData intentData : store.getPendingData(true, periodMs)) { |
228 | - //TODO should we do age check here, or in the store? | ||
229 | resubmitPendingRequest(intentData); | 230 | resubmitPendingRequest(intentData); |
230 | stuckCount++; | 231 | stuckCount++; |
231 | } | 232 | } | ... | ... |
-
Please register or login to post a comment