ONOS-4572 Adding checkstyle for Java tests in Buck

Change-Id: I3099046ba9db4ff59a9c4d0aa6bd0a73edc367d2

@@ -18,6 +18,39 @@ def _get_name():
     base_path = get_base_path()
     base_path = get_base_path()
     return ONOS_ARTIFACT_BASE + base_path.replace('/', '-') #TODO Unix-separator
     return ONOS_ARTIFACT_BASE + base_path.replace('/', '-') #TODO Unix-separator
 
 
+def checkstyle(
+    name,
+    srcs = None,
+    jar_target = None,
+    ):
+
+    if srcs and jar_target:
+        base = get_base_path()
+        files = '%s\n%s\n' % (name, base) + '\n'.join(['%s/%s' % (base, s) for s in srcs])
+
+        genrule(
+                name = name + '-checkstyle-files',
+                bash = "echo '%s' > $OUT" % files,
+                srcs = srcs,
+                out = 'checkstyle-files.txt',
+        )
+
+        sh_test(
+                name = name + '-checkstyle',
+                test = '//tools/build/conf:start-checkstyle',
+                deps = [ jar_target ],
+                args = [
+                    '$(location //tools/build/conf:checkstyle-jar)',
+                    '$(location :' + name + '-checkstyle-files)',
+                    '$(location //tools/build/conf:checkstyle-xml)',
+                    '$(location //tools/build/conf:suppressions-xml)',
+                    ],
+                test_rule_timeout_ms = 20000,
+                labels = [ 'checkstyle' ],
+        )
+    else:
+        print 'Not generating checkstyle rule for %s because there are no sources.' % name
+
 def osgi_jar(
 def osgi_jar(
     name = None,
     name = None,
     srcs = None,
     srcs = None,
@@ -109,35 +142,12 @@ def osgi_jar(
   )
   )
 
 
   ### Checkstyle
   ### Checkstyle
-  if srcs:
-    base = get_base_path()
-    files = '%s\n%s\n' % (name, base) + '\n'.join(['%s/%s' % (base, s) for s in srcs])
-
-    genrule(
+  checkstyle(
       name = name + '-checkstyle-files',
       name = name + '-checkstyle-files',
-      bash = "echo '%s' > $OUT" % files,
       srcs = srcs,
       srcs = srcs,
-      out = 'checkstyle-files.txt',
+      jar_target = ':'+ bare_jar_name,
   )
   )
 
 
-    sh_test(
-      name = name + '-checkstyle',
-      test = '//tools/build/conf:start-checkstyle',
-      deps = [
-               ':'+ bare_jar_name,
-             ],
-      args = [
-                '$(location //tools/build/conf:checkstyle-jar)',
-                '$(location :' + name + '-checkstyle-files)',
-                '$(location //tools/build/conf:checkstyle-xml)',
-                '$(location //tools/build/conf:suppressions-xml)',
-             ],
-      test_rule_timeout_ms = 20000,
-      labels = [ 'checkstyle' ],
-    )
-  else:
-    print 'Not generating checkstyle rule for %s because there are no sources.' % name
-
   # TODO add project config for intellij
   # TODO add project config for intellij
   # project_config(
   # project_config(
   #   src_target = ':' + bare_jar_name,
   #   src_target = ':' + bare_jar_name,
@@ -211,4 +221,10 @@ def osgi_jar_with_tests(
     visibility = visibility
     visibility = visibility
   )
   )
 
 
+  checkstyle(
+      name = name + '-tests',
+      srcs = test_srcs,
+      jar_target = ':' + name + '-tests',
+  )
+
   #FIXME need to run checkstyle on test sources
   #FIXME need to run checkstyle on test sources