STC stacktrace fixes

- Shut down openflow meta app before driver test,
  was causing port collision issues with openflow server

- Fixed NPE in Network config store

- reordered tests to insure proper sequencing

Change-Id: Ib39330153f543ee960b8631a0dc9246ee4251851

@@ -173,10 +173,13 @@ public class DistributedNetworkConfigStore
     private void processExistingConfigs(ConfigFactory configFactory) {
     private void processExistingConfigs(ConfigFactory configFactory) {
         ImmutableSet.copyOf(configs.keySet()).forEach(k -> {
         ImmutableSet.copyOf(configs.keySet()).forEach(k -> {
             if (Objects.equals(configFactory.configClass().getName(), k.configClass)) {
             if (Objects.equals(configFactory.configClass().getName(), k.configClass)) {
-                JsonNode json = configs.remove(k).value();
+                Versioned<JsonNode> remove = configs.remove(k);
+                if (remove != null) {
+                    JsonNode json = remove.value();
                     configs.put(key(k.subject, configFactory.configKey()), json);
                     configs.put(key(k.subject, configFactory.configKey()), json);
                     log.debug("Set config pending: {}, {}", k.subject, k.configClass);
                     log.debug("Set config pending: {}, {}", k.subject, k.configClass);
                 }
                 }
+            }
         });
         });
     }
     }
 
 

@@ -27,6 +27,10 @@
         <step name="DriversTest.CheckDefault" requires="^"
         <step name="DriversTest.CheckDefault" requires="^"
               exec="test '${defaultDriver}' != ''"/>
               exec="test '${defaultDriver}' != ''"/>
 
 
+        <!-- Deactivate openfow app - prevents spawning multiple controllers -->
+        <step name="DriversTest.DeactivateOpenflowApp" requires="^"
+              exec="onos ${OCI} onos:app deactivate org.onosproject.openflow"/>
+
         <!-- Deactivate drivers app -->
         <!-- Deactivate drivers app -->
         <step name="DriversTest.DeactivateDriversApp" requires="^"
         <step name="DriversTest.DeactivateDriversApp" requires="^"
               exec="onos ${OCI} onos:app deactivate org.onosproject.drivers"/>
               exec="onos ${OCI} onos:app deactivate org.onosproject.drivers"/>
@@ -37,6 +41,10 @@
         <step name="DriversTest.AfterDeactivateFindDefault" requires="^"
         <step name="DriversTest.AfterDeactivateFindDefault" requires="^"
               exec="onos-find-driver ${OC1} default defaultInactive" env="!"/>
               exec="onos-find-driver ${OC1} default defaultInactive" env="!"/>
 
 
+        <!-- Reactivate openflow apps -->
+        <step name="DriversTest.ActivateOpenflowApp" requires="^"
+              exec="onos ${OCI} onos:app activate org.onosproject.openflow"/>
+
         <!-- Reactivate all drivers -->
         <!-- Reactivate all drivers -->
         <step name="DriversTest.ActivateDriversApp" requires="^"
         <step name="DriversTest.ActivateDriversApp" requires="^"
               exec="onos ${OCI} onos:app activate org.onosproject.drivers"/>
               exec="onos ${OCI} onos:app activate org.onosproject.drivers"/>

@@ -23,18 +23,18 @@
     <import file="${ONOS_SCENARIOS}/net-smoke.xml"/>
     <import file="${ONOS_SCENARIOS}/net-smoke.xml"/>
     <dependency name="Net-Smoke" requires="Setup"/>
     <dependency name="Net-Smoke" requires="Setup"/>
 
 
-    <import file="${ONOS_SCENARIOS}/meta-apps-test.xml"/>
-    <dependency name="Meta-App" requires="Setup,~Net-Smoke"/>
-
     <import file="${ONOS_SCENARIOS}/archetypes.xml"/>
     <import file="${ONOS_SCENARIOS}/archetypes.xml"/>
     <dependency name="Archetypes" requires="Setup,~Net-Smoke"/>
     <dependency name="Archetypes" requires="Setup,~Net-Smoke"/>
 
 
-    <import file="${ONOS_SCENARIOS}/netcfg.xml"/>
-    <dependency name="Netcfg" requires="Setup,~Meta-App"/>
-
     <import file="${ONOS_SCENARIOS}/drivers-test.xml"/>
     <import file="${ONOS_SCENARIOS}/drivers-test.xml"/>
     <dependency name="Drivers-Test" requires="Setup,~Net-Smoke,~Archetypes"/>
     <dependency name="Drivers-Test" requires="Setup,~Net-Smoke,~Archetypes"/>
 
 
+    <import file="${ONOS_SCENARIOS}/meta-apps-test.xml"/>
+    <dependency name="Meta-App" requires="Setup,~Net-Smoke,~Drivers-Test"/>
+
+    <import file="${ONOS_SCENARIOS}/netcfg.xml"/>
+    <dependency name="Netcfg" requires="Setup,~Meta-App"/>
+
     <import file="${ONOS_SCENARIOS}/wrapup.xml"/>
     <import file="${ONOS_SCENARIOS}/wrapup.xml"/>
     <dependency name="Wrapup" requires="~Archetypes,~Setup,~Net-Smoke,~Drivers-Test,~Meta-App,~Netcfg"/>
     <dependency name="Wrapup" requires="~Archetypes,~Setup,~Net-Smoke,~Drivers-Test,~Meta-App,~Netcfg"/>
 </scenario>
 </scenario>