Remove magic numbers and in-line string constants in UiExtensionManager.

Change-Id: I574db918c46835c6033a1a4b90a30caa3540f144

@@ -74,13 +74,20 @@ import static org.onosproject.ui.UiView.Category.PLATFORM;
  */
  */
 @Component(immediate = true)
 @Component(immediate = true)
 @Service
 @Service
-public class UiExtensionManager implements UiExtensionService, UiPreferencesService, SpriteService {
+public class UiExtensionManager
+        implements UiExtensionService, UiPreferencesService, SpriteService {
 
 
     private static final ClassLoader CL = UiExtensionManager.class.getClassLoader();
     private static final ClassLoader CL = UiExtensionManager.class.getClassLoader();
+
+    private static final String ONOS_USER_PREFERENCES = "onos-user-preferences";
     private static final String CORE = "core";
     private static final String CORE = "core";
     private static final String GUI_ADDED = "guiAdded";
     private static final String GUI_ADDED = "guiAdded";
     private static final String GUI_REMOVED = "guiRemoved";
     private static final String GUI_REMOVED = "guiRemoved";
     private static final String UPDATE_PREFS = "updatePrefs";
     private static final String UPDATE_PREFS = "updatePrefs";
+    private static final String SLASH = "/";
+
+    private static final int IDX_USER = 0;
+    private static final int IDX_KEY = 1;
 
 
     private final Logger log = LoggerFactory.getLogger(getClass());
     private final Logger log = LoggerFactory.getLogger(getClass());
 
 
@@ -168,7 +175,7 @@ public class UiExtensionManager implements UiExtensionService, UiPreferencesServ
                         IntNode.class, NullNode.class);
                         IntNode.class, NullNode.class);
 
 
         prefs = storageService.<String, ObjectNode>eventuallyConsistentMapBuilder()
         prefs = storageService.<String, ObjectNode>eventuallyConsistentMapBuilder()
-                .withName("onos-user-preferences")
+                .withName(ONOS_USER_PREFERENCES)
                 .withSerializer(kryoBuilder)
                 .withSerializer(kryoBuilder)
                 .withTimestampProvider((k, v) -> new WallClockTimestamp())
                 .withTimestampProvider((k, v) -> new WallClockTimestamp())
                 .withPersistence()
                 .withPersistence()
@@ -229,7 +236,7 @@ public class UiExtensionManager implements UiExtensionService, UiPreferencesServ
     public Map<String, ObjectNode> getPreferences(String userName) {
     public Map<String, ObjectNode> getPreferences(String userName) {
         ImmutableMap.Builder<String, ObjectNode> builder = ImmutableMap.builder();
         ImmutableMap.Builder<String, ObjectNode> builder = ImmutableMap.builder();
         prefs.entrySet().stream()
         prefs.entrySet().stream()
-                .filter(e -> e.getKey().startsWith(userName + "/"))
+                .filter(e -> e.getKey().startsWith(userName + SLASH))
                 .forEach(e -> builder.put(keyName(e.getKey()), e.getValue()));
                 .forEach(e -> builder.put(keyName(e.getKey()), e.getValue()));
         return builder.build();
         return builder.build();
     }
     }
@@ -261,15 +268,16 @@ public class UiExtensionManager implements UiExtensionService, UiPreferencesServ
     }
     }
 
 
     private String key(String userName, String keyName) {
     private String key(String userName, String keyName) {
-        return userName + "/" + keyName;
+        return userName + SLASH + keyName;
     }
     }
 
 
+
     private String userName(String key) {
     private String userName(String key) {
-        return key.split("/")[0];
+        return key.split(SLASH)[IDX_USER];
     }
     }
 
 
     private String keyName(String key) {
     private String keyName(String key) {
-        return key.split("/")[1];
+        return key.split(SLASH)[IDX_KEY];
     }
     }
 
 
     // Auxiliary listener to preference map events.
     // Auxiliary listener to preference map events.